[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop calling top level pub #89032

Merged
merged 10 commits into from
Aug 30, 2021
Merged

Stop calling top level pub #89032

merged 10 commits into from
Aug 30, 2021

Conversation

sigurdm
Copy link
Contributor
@sigurdm sigurdm commented Aug 27, 2021 •
edited

This avoid the deprecation notice from the top level pub tool.

Fixes: #88507

Ideally we would shell out to dart pub but we want to take that step later.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

@sigurdm
Use dart __deprecated_pub instead of pub to invoke pub from tools
89be7dc 
The top level `pub` commmand has been deprecated and will print
a message. It is however implemented via the __deprecated_pub command
that prints no message.

:# Date:      Thu Aug 19 09:05:16 2021 +0000
@sigurdm
Fix TODO
7fa3107
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 27, 2021
@google-cla google-cla bot added the cla: yes label Aug 27, 2021
@sigurdm sigurdm mentioned this pull request Aug 27, 2021
Closed
christopherfujino
christopherfujino requested changes Aug 27, 2021
View reviewed changes
Copy link
Member
@christopherfujino christopherfujino left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the __deprecated_pub

was the license removal a mistake?

Also, what was the problem that led to the earlier version of this getting reverted?

@sigurdm
Copy link
Contributor Author
sigurdm commented Aug 30, 2021

Also, what was the problem that led to the earlier version of this getting reverted?

When we made dart pub we did not bring over the advanced --verbosity options thinking that they are rarely used and can be replaced by grep'ping the output from --verbose.

But it turns out flutter depends on --verbosity=warning. Not sure about what exactly happened in the given test case - but surely the parsing of the output of dart pub failed.

We might end up reconsidering this. But we would rather work on aligning flutter pub get so much with dart pub get that flutter_tools would not have to do its own post-processing.

christopherfujino
christopherfujino approved these changes Aug 30, 2021
View reviewed changes
Copy link
Member
@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense. thanks for this change, LGTM

@christopherfujino christopherfujino merged commit bce3662 into flutter:master Aug 30, 2021
@zanderso zanderso mentioned this pull request Jul 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use dart pub instead of pub from flutter_tools
2 participants
@sigurdm @christopherfujino