-
Notifications
You must be signed in to change notification settings - Fork 27.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop calling top level pub #89032
Stop calling top level pub #89032
Conversation
The top level `pub` commmand has been deprecated and will print a message. It is however implemented via the __deprecated_pub command that prints no message. :# Date: Thu Aug 19 09:05:16 2021 +0000
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the __deprecated_pub
was the license removal a mistake?
Also, what was the problem that led to the earlier version of this getting reverted?
When we made But it turns out flutter depends on We might end up reconsidering this. But we would rather work on aligning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense. thanks for this change, LGTM
This avoid the deprecation notice from the top level
pub
tool.Fixes: #88507
Ideally we would shell out to
dart pub
but we want to take that step later.Pre-launch Checklist
///
).