[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consolidate all web integration tests under the same shard #82307

Merged
merged 6 commits into from
May 12, 2021
Merged

consolidate all web integration tests under the same shard #82307

merged 6 commits into from
May 12, 2021

Conversation

yjbanov
Copy link
Contributor
@yjbanov yjbanov commented May 12, 2021
  • Increase the number of sub-shards in web_long_running_tests from 3 to 5 and merge all remaining integration tests under it.
  • Remove the web_integration_tests shard (it doesn't scale well because it doesn't support sub-shards)

@flutter-dashboard flutter-dashboard bot added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label May 12, 2021
@google-cla google-cla bot added the cla: yes label May 12, 2021
keyonghan
keyonghan approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor
@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This needs to land after https://github.com/flutter/infra/pull/445.

@yjbanov yjbanov force-pushed the consolidate-web-integration-tests branch 3 times, most recently from 64a0c81 to 3ceb3f6 Compare May 12, 2021 17:35
@yjbanov yjbanov force-pushed the consolidate-web-integration-tests branch from 3ceb3f6 to b91dcc3 Compare May 12, 2021 17:52
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux web_long_running_tests_1_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite analyze-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@yjbanov
Copy link
Contributor Author
yjbanov commented May 12, 2021

Landing now to unblock PRs. Pending stuff is not related to web.

@yjbanov yjbanov merged commit 0420d56 into flutter:master May 12, 2021
@Hixie Hixie mentioned this pull request Aug 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyonghan keyonghan keyonghan approved these changes

@godofredoc godofredoc Awaiting requested review from godofredoc

@CaseyHillers CaseyHillers Awaiting requested review from CaseyHillers

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

Assignees
No one assigned
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yjbanov @fluttergithubbot @keyonghan