Enable no_leading_underscores_for_library_prefixes #96420
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| import '_bitfield_io.dart' | ||
| if (dart.library.html) '_bitfield_web.dart' as _bitfield; | ||
| if (dart.library.html) '_bitfield_web.dart' as bitfield; |
There was a problem hiding this comment.
I would argue that these filenames should probably also be renamed to not start with an "_". That way, they will appear right next to this file when files are sorted alphabetically.
There was a problem hiding this comment.
I'll send a separate PR for that.
There's a proposal to add
no_leading_underscores_for_library_prefixesto package:lints (dart-lang/lints#58). This checks what impact that would have on the flutter code base.In most places we don't use underscores so this lint provides some nice unification across the code base.
/cc @pq