[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Enable avoid_print lint." #91438

Merged
merged 1 commit into from
Oct 7, 2021
Merged

Revert "Enable avoid_print lint." #91438

merged 1 commit into from
Oct 7, 2021

Conversation

mdebbar
Copy link
Contributor
@mdebbar mdebbar commented Oct 7, 2021

Reverts #91332

This PR made the engine tree red because it's failing for web tests: #91432

I don't think the PR has any issues in itself, so we can reland it once we figure out why markTestSkipped is failing on web.

@mdebbar mdebbar requested review from Hixie and zanderso October 7, 2021 20:10
@mdebbar mdebbar requested a review from Piinks as a code owner October 7, 2021 20:10
@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems d: examples Sample code and demos f: focus Focus traversal, gaining or losing focus f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels Oct 7, 2021
@google-cla google-cla bot added the cla: yes label Oct 7, 2021
@mdebbar mdebbar merged commit c2ea78d into master Oct 7, 2021
@mdebbar mdebbar deleted the revert-91332-avoid_print branch October 7, 2021 20:16
@mdebbar mdebbar mentioned this pull request Oct 7, 2021
Merged
@zanderso
Copy link
Member
zanderso commented Oct 7, 2021

lgtm

@Hixie Hixie mentioned this pull request Oct 7, 2021
Merged
@Hixie
Copy link
Contributor
Hixie commented Oct 7, 2021

Relanding in #91444.

clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Oct 29, 2021
@mdebbar @clocksmith
Revert "Enable avoid_print lint. (flutter#91332)" (flutter#91438)
2eef7c1 
This reverts commit cb378ed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hixie Hixie Awaiting requested review from Hixie

@zanderso zanderso Awaiting requested review from zanderso

@Piinks Piinks Awaiting requested review from Piinks

Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems d: examples Sample code and demos f: focus Focus traversal, gaining or losing focus f: integration_test The flutter/packages/integration_test plugin f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mdebbar @zanderso @Hixie