[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Enable avoid_redundant_argument_values lint" #91461

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Revert "Enable avoid_redundant_argument_values lint" #91461

merged 1 commit into from
Oct 8, 2021

Conversation

zanderso
Copy link
Member
@zanderso zanderso commented Oct 8, 2021

@zanderso zanderso requested a review from Hixie October 8, 2021 03:38
@google-cla google-cla bot added the cla: yes label Oct 8, 2021
@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: animation Animation APIs a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: focus Focus traversal, gaining or losing focus f: gestures flutter/packages/flutter/gestures repository. f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels Oct 8, 2021
@zanderso
Copy link
Member Author
zanderso commented Oct 8, 2021

This somehow slipped through while the tree was red.

@zanderso zanderso merged commit b9d2177 into master Oct 8, 2021
@zanderso zanderso deleted the revert-91409-default_arguments branch October 8, 2021 04:11
@Hixie Hixie mentioned this pull request Oct 8, 2021
Merged
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Oct 29, 2021
@zanderso @clocksmith
Revert "Enable avoid_redundant_argument_values lint (flutter#91409)" (f…
7a70454 
…lutter#91461)

This reverts commit 5fd259b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godofredoc godofredoc godofredoc approved these changes

@Hixie Hixie Awaiting requested review from Hixie

Assignees
No one assigned
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: animation Animation APIs a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: focus Focus traversal, gaining or losing focus f: gestures flutter/packages/flutter/gestures repository. f: integration_test The flutter/packages/integration_test plugin f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zanderso @godofredoc