-
Notifications
You must be signed in to change notification settings - Fork 27.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable sort_child_properties_last
lint
#91585
Enable sort_child_properties_last
lint
#91585
Conversation
cc @goderbauer for framework |
clipper: ShapeBorderClipper( | ||
shape: RoundedRectangleBorder( | ||
borderRadius: BorderRadius.circular(10.0), | ||
)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clipper: ShapeBorderClipper( | |
shape: RoundedRectangleBorder( | |
borderRadius: BorderRadius.circular(10.0), | |
)), | |
clipper: ShapeBorderClipper( | |
shape: RoundedRectangleBorder( | |
borderRadius: BorderRadius.circular(10.0), | |
), | |
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch! will fix
@@ -16,14 +16,14 @@ class LogoScreen extends StatelessWidget { | |||
Widget build(BuildContext context) { | |||
print(_testSentinel); | |||
return Container( | |||
padding: const EdgeInsets.all(25), | |||
color: Colors.blue, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
color: Colors.blue, | |
color: Colors.blue, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Zazo032 thanks for your excellent code review, I totally missed both of those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're welcome 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
04547b1
to
064e0b9
Compare
This pull request is not suitable for automatic merging in its current state.
|
Google testing failure is because the roll is so far behind this conflicts with other changes. |
No description provided.