Enable more lints #91642
Enable more lints #91642
Conversation
|
cc @goderbauer here's another one! :-) |
|
Given all these ignores, I am not convinced that Same with Scrolling through the PR, a saw maybe two cases where these two lints improved the code slightly, at the cost of 90+ ignores... |
|
Roger, I'll mark it as blocked on dart-lang/linter#3023 and remove the ignores. |
269ebd6
to
a92511f
Compare
|
@goderbauer PTAL |
|
Same of the ignores for the now disabled |
|
They're intended to make turning on the lint easier when the lint is adjusted to remove the obvious false positives. I wasn't aware we were doing "remove ignores that are not ignoring anything" clean-up, is that automated at all? |
|
Regarding automation: There was work underway to warn about ignores that are not ignoring anything to avoid getting them into the code base in the first place and to require clean-up when the underlying bug was fixed: dart-lang/sdk#35234. That has stalled, though. |
|
I would prefer submitting this without the currently unnecessary ignores. Who knows how long it will take to fix the false positives, but I also don't feel super strongly about this. So, LGTM. |
This enables: - avoid_double_and_int_checks - avoid_js_rounded_ints - unsafe_html - use_setters_to_change_properties It also fixes a few places where the lints were violated. It does not enable `avoid_catches_without_on_clauses` or `avoid_catching_errors` but it does prepare us for a world where those lints have fewer false positives; see dart-lang/linter#3023 for details.
|
Ok, I've changed them to regular comments. |
This enables:
It also fixes a few places where the lints were violated.
It does not enable
avoid_catches_without_on_clausesoravoid_catching_errorsbut it does prepare us for a world where those lints have fewer false positives; see dart-lang/linter#3023 for details.