-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[various] Update Pigeon in Obj-C plugins #3662
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this, @stuartmorgan!
[various] Update Pigeon in Obj-C plugins
Xcode 14.3 includes (via clang 15) a new warning about mismatches between a C function declared as
foo(void)
and (incorrectly) defined asfoo()
. Pigeon generated that mismatch in Obj-C code, which was fixed in 9.2.4; this updates all Obj-C plugins that use Pigeon to 9.2.4 to pick up that fix, so that they don't have warnings (and thus fail CI in the future) with Xcode 14.3.All code changes in this PR were generated, with the exception of the
NSError
->FlutterError
type change in FlutterApi calls (from Pigeon 8.0). This is a trivial change though, as currently FlutterApi never actually returns errors in practice, so there's no code using them other than to assert and log.Addresses flutter/flutter#124343 for all plugins
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).