labeledTapTargetGuideline should passe if textfield does not have lab…

…el (#116221)
flutter · Nov 30, 2022 · 6b98f2c · 6b98f2c
1 parent 9532b91
commit 6b98f2c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/packages/flutter_test/lib/src/accessibility.dart b/packages/flutter_test/lib/src/accessibility.dart
@@ -219,7 +219,8 @@ class LabeledTapTargetGuideline extends AccessibilityGuideline {
       });
       if (node.isMergedIntoParent ||
           node.isInvisible ||
-          node.hasFlag(ui.SemanticsFlag.isHidden)) {
+          node.hasFlag(ui.SemanticsFlag.isHidden) ||
+          node.hasFlag(ui.SemanticsFlag.isTextField)) {
         return result;
       }
       final SemanticsData data = node.getSemanticsData();

diff --git a/packages/flutter_test/test/accessibility_test.dart b/packages/flutter_test/test/accessibility_test.dart
@@ -874,6 +874,14 @@ void main() {
       expect(result.passed, true);
       handle.dispose();
     });
+
+    testWidgets('Passes if text field does not have label', (WidgetTester tester) async {
+      final SemanticsHandle handle = tester.ensureSemantics();
+      await tester.pumpWidget(_boilerplate(const TextField()));
+      final Evaluation result = await labeledTapTargetGuideline.evaluate(tester);
+      expect(result.passed, true);
+      handle.dispose();
+    });
   });
 
   testWidgets('regression test for material widget',