[go: nahoru, domu]

Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Commit

Permalink
[ci] Update iOS simulator (#7131)
Browse files Browse the repository at this point in the history
Updates the iOS simulator used in CI from an iPhone 11 to an iPhone 13.

Part of alignment with flutter/packages in preparation for merging repositories.

Updates a Maps integration test for issues with the newer device.
  • Loading branch information
stuartmorgan committed Feb 16, 2023
1 parent d699b4a commit cd09d9d
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 18 deletions.
2 changes: 1 addition & 1 deletion .ci/scripts/create_simulator.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

device=com.apple.CoreSimulator.SimDeviceType.iPhone-11
device=com.apple.CoreSimulator.SimDeviceType.iPhone-13
os=com.apple.CoreSimulator.SimRuntime.iOS-16-0

xcrun simctl list
Expand Down
2 changes: 1 addition & 1 deletion .ci/targets/ios_platform_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ tasks:
args: ["xcode-analyze", "--ios", "--ios-min-version=13.0"]
- name: native test
script: script/tool_runner.sh
args: ["native-test", "--ios", "--ios-destination", "platform=iOS Simulator,name=iPhone 11,OS=latest"]
args: ["native-test", "--ios", "--ios-destination", "platform=iOS Simulator,name=iPhone 13,OS=latest"]
- name: drive examples
# `drive-examples` contains integration tests, which changes the UI of the application.
# This UI change sometimes affects `xctest`.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,31 +53,35 @@ class _MapCoordinatesBodyState extends State<_MapCoordinatesBody> {
_updateVisibleRegion();
return true;
},
child: ListView(
child: Stack(
children: <Widget>[
Padding(
padding: const EdgeInsets.all(10.0),
child: Center(
child: SizedBox(
width: 300.0,
height: 200.0,
child: googleMap,
ListView(
children: <Widget>[
Padding(
padding: const EdgeInsets.all(10.0),
child: Center(
child: SizedBox(
width: 300.0,
height: 200.0,
child: googleMap,
),
),
),
),
// Add a block at the bottom of this list to allow validation that the visible region of the map
// does not change when scrolled under the safe view on iOS.
// https://github.com/flutter/flutter/issues/107913
const SizedBox(
width: 300,
height: 1000,
),
],
),
if (mapController != null)
Center(
child: Text('VisibleRegion:'
'\nnortheast: ${_visibleRegion.northeast},'
'\nsouthwest: ${_visibleRegion.southwest}'),
),
// Add a block at the bottom of this list to allow validation that the visible region of the map
// does not change when scrolled under the safe view on iOS.
// https://github.com/flutter/flutter/issues/107913
const SizedBox(
width: 300,
height: 1000,
),
],
),
);
Expand Down

0 comments on commit cd09d9d

Please sign in to comment.