[go: nahoru, domu]
Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Remove Flutterfire plugins (moved to FirebaseExtended) #1984

Merged
merged 7 commits into from
Aug 22, 2019
Merged

Remove Flutterfire plugins (moved to FirebaseExtended) #1984

merged 7 commits into from
Aug 22, 2019

Conversation

collinjackson
Copy link
Contributor
@collinjackson collinjackson commented Aug 16, 2019 •
edited
Loading

We are moving FlutterFire code and issues from the flutter/plugins repo to FirebaseExtended/flutterfire.

This will make them easier for Firebase users to discover.

The package names will remain the same.

kroikie
kroikie approved these changes Aug 17, 2019
View reviewed changes
Copy link
Contributor
@kroikie kroikie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is just deleting the FlutterFire plugins. LGTM

@kroikie
Copy link
Contributor
kroikie commented Aug 17, 2019

build all plugins will have to be updated

bparrishMines
bparrishMines approved these changes Aug 19, 2019
View reviewed changes
Copy link
Contributor
@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I was able to get the all_plugins test to pass locally by adding

implementation 'com.google.guava:guava:27.0.1-android'

to the app build.gradle.

@collinjackson
Copy link
Contributor Author

implementation 'com.google.guava:guava:27.0.1-android'

Thanks! I appreciate your help on this.

@bparrishMines bparrishMines mentioned this pull request Aug 20, 2019
Closed
@collinjackson collinjackson merged commit 3ad2d1d into flutter:master Aug 22, 2019
@collinjackson collinjackson deleted the remove_flutterfire branch August 22, 2019 19:40
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
@collinjackson
Remove Flutterfire plugins (moved to FirebaseExtended) (flutter#1984)
29d83a6 
* Remove Flutterfire plugins (moved to FirebaseExtended)

* Remove Flutterfire references from build_all_plugins_app
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kroikie kroikie kroikie approved these changes

@bparrishMines bparrishMines bparrishMines approved these changes

@amirh amirh Awaiting requested review from amirh

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
4 participants
@collinjackson @kroikie @bparrishMines @googlebot