This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[google_sign_in] Use implementation rather than api dependencies for plugin third-party dependencies. #2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to land the update to Google Sign-in while discarding the changes to local_auth and android_alarm_manager. It looks like both of their example apps were relying on the transitive androidx support library dependency in their example apps. If there are calls between the app developer's Java code and the plugin's Java code (beyond basic plugin registration), it makes more sense to use an API dependency. |
mormih
pushed a commit
to mormih/plugins
that referenced
this pull request
Nov 17, 2019
…plugin third-party dependencies. (flutter#2015) * Use implementation rather than API dependencies for google_sign_in
sungmin-park
pushed a commit
to sungmin-park/flutter-plugins
that referenced
this pull request
Dec 17, 2019
…plugin third-party dependencies. (flutter#2015) * Use implementation rather than API dependencies for google_sign_in
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same idea as firebase/flutterfire#39 -- we shouldn't overly constrain Gradle's version resolution for internal dependencies.