[go: nahoru, domu]
Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[google_sign_in] Fix deprecated API usage issue by upgrading CocoaPod to 5.0 #2127

Merged
merged 10 commits into from
Oct 29, 2019
Merged

[google_sign_in] Fix deprecated API usage issue by upgrading CocoaPod to 5.0 #2127

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
710283b
Fix Deprecated API Usage issue
collinjackson Sep 30, 2019
9b7eac5
Update to 5.0 compatibility
collinjackson Sep 30, 2019
89187b5
reformat
collinjackson Sep 30, 2019
46d23e3
Update to use [registrar messenger]
collinjackson Oct 1, 2019
f0bb3ce
Merge remote-tracking branch 'origin/master' into google_sign_in
collinjackson Oct 22, 2019
52ed349
Implement code review feedback
collinjackson Oct 22, 2019
34abc18
Remove dead code
collinjackson Oct 22, 2019
2faa78b
Merge remote-tracking branch 'origin/master' into google_sign_in
collinjackson Oct 25, 2019
bb5c3eb
format
collinjackson Oct 25, 2019
e3a79a8
Merge remote-tracking branch 'origin/master' into google_sign_in
collinjackson Oct 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix Deprecated API Usage issue
  • Loading branch information
@collinjackson
collinjackson committed Sep 30, 2019
commit 710283be08449d99e5fcb2ad4703580d18072293
4 changes: 4 additions & 0 deletions packages/google_sign_in/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 4.0.10

* Update iOS CocoaPod dependency to 5.0 to fix deprecated API usage issue.

## 4.0.9

* Update and migrate iOS example project.
Expand Down
2 changes: 1 addition & 1 deletion packages/google_sign_in/ios/google_sign_in.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ Enables Google Sign-In in Flutter apps.
s.source_files = 'Classes/**/*'
s.public_header_files = 'Classes/**/*.h'
s.dependency 'Flutter'
s.dependency 'GoogleSignIn', '~> 4.0'
s.dependency 'GoogleSignIn', '~> 5.0'
s.static_framework = true
end
2 changes: 1 addition & 1 deletion packages/google_sign_in/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: Flutter plugin for Google Sign-In, a secure authentication system
for signing in with a Google account on Android and iOS.
author: Flutter Team <flutter-dev@googlegroups.com>
homepage: https://github.com/flutter/plugins/tree/master/packages/google_sign_in
version: 4.0.9
version: 4.0.10
Copy link
@Knupper Knupper Oct 17, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we not update the version to 5.x.x as well to indicate wich GoogleSignIn Version is used inside?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally we don't update the Dart and wrapped SDK versions in lockstep. In this case, we're not making a breaking change to the semantics of the Dart plugin, so I don't think a major version increment is needed.


flutter:
plugin:
Expand Down