This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[package_info] Support the v2 Android embedder (with e2e tests) #2160
[package_info] Support the v2 Android embedder (with e2e tests) #2160
Changes from 1 commit
85172df
17bd422
fe8d3a8
83dd9f0
0946eeb
ab5be52
a4fc6ba
4cb7bf2
a9866da
0639c46
55813be
e7d4f21
ff1e2cf
1c6448c
1e9cc06
502e72f
e3107bf
2a0c3cc
f7717af
f9c7d16
7c928fc
a624929
6c996fb
45a6d9d
397395d
c44fed0
e276af0
ba5ea93
83db9b7
fd15c6d
6160d81
0bd7375
2af8457
0121e9e
e5a370b
4f2ab2f
ced1f8d
054b1a0
91be486
265127f
1e8f811
e497d95
f21476a
a2bca9c
77d22f3
a0c5273
b6c0ceb
d95a8c5
d1b8e10
881c1c9
a42674b
64e3352
491234f
a16cfd2
1e84ad0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: add a TODO to remove this once the generated registrant for the v2 embedder is on stable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, we should probably make this change in the battery plugin also
https://github.com/flutter/plugins/blob/master/packages/battery/example/android/app/src/main/java/io/flutter/plugins/batteryexample/MainActivity.java