[go: nahoru, domu]
Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Update CONTRIBUTING.md to allow mockito #2292

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Update CONTRIBUTING.md to allow mockito #2292

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,13 +101,6 @@ Plugins tests are run automatically on contributions using Cirrus CI. However, d
cost constraints, pull requests from non-committers may not run all the tests
automatically.

The plugins team prefers that unit tests are written using `setMockMethodCallHandler`
rather than using mockito to mock out `MethodChannel`. For a list of the plugins that
are still using the mockito testing style and need to be converted, see
[issue 34284](https://github.com/flutter/flutter/issues/34284). If you are contributing
tests to an existing plugin that uses mockito `MethodChannel`, consider converting
them to use `setMockMethodCallHandler` instead.

Once you've gotten an LGTM from a project maintainer and once your PR has received
the green light from all our automated testing, wait for one the package maintainers
to merge the pull request and `pub submit` any affected packages.
Expand Down