This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[flutter_plugin_tools] Improve package targeting #4577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
approved these changes
Dec 4, 2021
Comment on lines
+4
to
+5
| - `--packages` now allows using a federated plugin's package as a target without | ||
| fully specifying it (if it is not the same as the plugin's name). E.g., |
There was a problem hiding this comment.
Should this information be in the help page for the tool?
There was a problem hiding this comment.
Good idea, done.
| // if .../packages/parentName/candidatePackageName/... | ||
| // looks like a path in a federated plugin package (candidatePackageName) | ||
| // rather than a top-level package (parentName). | ||
| bool isFederatedPackage(String candidatePackageName, String parentName) { |
There was a problem hiding this comment.
s/isFederatedPackage/_isFederatedPackage
There was a problem hiding this comment.
Locals shouldn't be named with underscores.
Comment on lines
448
to
452
| // A helper function that returns true if candidateName looks like an | ||
| // implementation package of a plugin called pluginName. Used to determine | ||
| // if .../packages/parentName/candidatePackageName/... | ||
| // looks like a path in a federated plugin package (candidatePackageName) | ||
| // rather than a top-level package (parentName). |
There was a problem hiding this comment.
You might as well make this a docstring so you get compiler support about variable names and what not. There is already a mixmatch between "candidateName" and "candidatePackageName"
There was a problem hiding this comment.
This is a locally scoped function, which doesn't seem to support docstrings (at least not in VS Code). I fixed candidateName though.
|
This pull request is not suitable for automatic merging in its current state.
|
|
Overriding incorrect submit-queue check; it's pulling status from the previous publish run, not the current (successful) run. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 7, 2021
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Dec 11, 2021
Improve package targeting: - `--run-on-changed-packages` now includes only changed packages in a federated plugin, not all packages. Include all packages isn't useful since (without changes that would cause them to be included anyway) package dependencies are not path-based between packages. - `--packages` now allows specifying package names of federated plugins. E.g., `--packages=path_provider_ios` will now work, instead of requiring `--packages=path_provider/path_provider_ios`. The fully qualified form still works as well (and is still needed for app-facing packages to disambiguate from the plugin group). Fixes flutter/flutter#94618
KyleFin
pushed a commit
to KyleFin/plugins
that referenced
this pull request
Dec 21, 2021
Improve package targeting: - `--run-on-changed-packages` now includes only changed packages in a federated plugin, not all packages. Include all packages isn't useful since (without changes that would cause them to be included anyway) package dependencies are not path-based between packages. - `--packages` now allows specifying package names of federated plugins. E.g., `--packages=path_provider_ios` will now work, instead of requiring `--packages=path_provider/path_provider_ios`. The fully qualified form still works as well (and is still needed for app-facing packages to disambiguate from the plugin group). Fixes flutter/flutter#94618
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve package targeting:
--run-on-changed-packagesnow includes only changed packages in a federated plugin, not all packages. Include all packages isn't useful since (without changes that would cause them to be included anyway) package dependencies are not path-based between packages.--packagesnow allows specifying package names of federated plugins. E.g.,--packages=path_provider_ioswill now work, instead of requiring--packages=path_provider/path_provider_ios. The fully qualified form still works as well (and is still needed for app-facing packages to disambiguate from the plugin group).Fixes flutter/flutter#94618
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).