[go: nahoru, domu]
Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Enable macOS XCTest support #4043

Merged
merged 14 commits into from
Jun 10, 2021
Merged

Enable macOS XCTest support #4043

merged 14 commits into from
Jun 10, 2021

Conversation

stuartmorgan
Copy link
Contributor
  • Adds macOS support to the xctest tool command
  • Adds logic to the tool to check for packages that delegate their implementations
    to another package, so they can be skipped when running native unit tests
    • Updates the tool's unit test utility for writing pubspecs to be able to make
      delegated federated implementation references to test it
  • Adds initial unit tests to the non-deprecated macOS plugins
  • Enables macOS XCTesting in CI

macOS portion of flutter/flutter#82445

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@google-cla google-cla bot added the cla: yes label Jun 10, 2021
jmagman
jmagman approved these changes Jun 10, 2021
View reviewed changes
Copy link
Member
@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan stuartmorgan merged commit 852051a into flutter:master Jun 10, 2021
@stuartmorgan stuartmorgan deleted the macos-unittests branch June 10, 2021 21:50
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 10, 2021
@engine-flutter-autoroll
852051a Enable macOS XCTest support (flutter/plugins#4043)
0987835
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@stuartmorgan @fotiDim
Enable macOS XCTest support (flutter#4043)
ca3ee31 
- Adds macOS support to the `xctest` tool command
- Adds logic to the tool to check for packages that delegate their implementations
  to another package, so they can be skipped when running native unit tests
  - Updates the tool's unit test utility for writing pubspecs to be able to make
    delegated federated implementation references to test it
- Adds initial unit tests to the non-deprecated macOS plugins
- Enables macOS XCTesting in CI

macOS portion of flutter/flutter#82445
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmagman jmagman jmagman approved these changes

@cbracken cbracken Awaiting requested review from cbracken

Assignees
No one assigned
Labels
cla: yes p: path_provider p: shared_preferences p: url_launcher platform-macos
Projects
None yet
Milestone
No milestone
2 participants
@stuartmorgan @jmagman