-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Enable prefer_relative_imports
#6501
Enable prefer_relative_imports
#6501
Conversation
Enables the `prefer_relative_imports` lint to align with flutter/flutter, and fixes all violations. Part of flutter/flutter#76229
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the remaining import fixes
Doh, forgot to check the tool when I ran locally. |
auto label is removed for flutter/plugins, pr: 6501, due to - The status or check suite legacy-version-analyze CHANNEL:3.0.5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
Oh, I see why I can't repro this locally. It's a lint error in the modifications made by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Enables the
prefer_relative_imports
lint to align withflutter/flutter, and fixes all violations.
Part of flutter/flutter#76229
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).