[go: nahoru, domu]
Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Enable prefer_relative_imports #6501

Merged
merged 5 commits into from
Sep 28, 2022
Merged

Enable prefer_relative_imports #6501

merged 5 commits into from
Sep 28, 2022

Conversation

stuartmorgan
Copy link
Contributor

Enables the prefer_relative_imports lint to align with
flutter/flutter, and fixes all violations.

Part of flutter/flutter#76229

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan
Enable prefer_relative_imports
eba516c 
Enables the `prefer_relative_imports` lint to align with
flutter/flutter, and fixes all violations.

Part of flutter/flutter#76229
@stuartmorgan
Version bumps
e12de9b
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

bparrishMines
bparrishMines approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor
@bparrishMines bparrishMines left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the remaining import fixes

@stuartmorgan
Copy link
Contributor Author

Doh, forgot to check the tool when I ran locally.

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 27, 2022
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 27, 2022
@auto-submit
Copy link
auto-submit bot commented Sep 27, 2022

auto label is removed for flutter/plugins, pr: 6501, due to - The status or check suite legacy-version-analyze CHANNEL:3.0.5 has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite downgraded_analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite analyze CHANNEL:master has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite legacy-version-analyze CHANNEL:2.10.5 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@stuartmorgan
Copy link
Contributor Author
stuartmorgan commented Sep 27, 2022 •
edited
Loading

Oh, I see why I can't repro this locally. It's a lint error in the modifications made by make-deps-path-based, which only shows up if you touch enough packages to have multiple overrides in the same package 😐 Hopefully that's a quick fix to the tool that I can just add in here.

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 27, 2022
@auto-submit auto-submit bot merged commit ded5528 into flutter:main Sep 28, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 28, 2022
@engine-flutter-autoroll
ded5528fa Enable prefer_relative_imports (flutter/plugins#6501)
7b21b9f
cbracken
cbracken reviewed Sep 29, 2022
View reviewed changes
Copy link
Member
@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

adam-harwood pushed a commit to adam-harwood/flutter_plugins that referenced this pull request Nov 3, 2022
@stuartmorgan
Enable prefer_relative_imports (flutter#6501)
908783e
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@stuartmorgan @mauricioluz
Enable prefer_relative_imports (flutter#6501)
5e4e003
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cbracken cbracken cbracken left review comments

@GaryQian GaryQian GaryQian approved these changes

@bparrishMines bparrishMines bparrishMines approved these changes

@hellohuanlin hellohuanlin hellohuanlin approved these changes

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

@camsim99 camsim99 Awaiting requested review from camsim99 camsim99 is a code owner

@ditman ditman Awaiting requested review from ditman ditman is a code owner

@gaaclarke gaaclarke Awaiting requested review from gaaclarke

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App needs tests p: camera p: file_selector p: google_maps_flutter p: image_picker p: in_app_purchase p: local_auth p: path_provider p: quick_actions p: url_launcher p: webview_flutter Edits files for a webview_flutter plugin platform-android platform-ios platform-macos platform-web platform-windows
Projects
None yet
Milestone
No milestone
5 participants
@stuartmorgan @cbracken @GaryQian @bparrishMines @hellohuanlin