This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[tool] Clean up "plugin" references #6503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarrinneal
reviewed
Sep 27, 2022
| test('lists plugins', () async { | ||
| createFakePlugin('plugin1', packagesDir); | ||
| test('lists top-level packages', () async { | ||
| createFakePackage('package1', packagesDir); | ||
| createFakePlugin('plugin2', packagesDir); |
There was a problem hiding this comment.
was leaving plugin2 (and later plugin3) intentional?
There was a problem hiding this comment.
Yes, it was to create a mix. Ideally more tests would be using a mix of plugins and packages just to make sure there aren't any unintended behaviors for one type but not the other.
tarrinneal
approved these changes
Sep 27, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 28, 2022
adam-harwood
pushed a commit
to adam-harwood/flutter_plugins
that referenced
this pull request
Nov 3, 2022
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically the tooling was written for plugins, and then was later extended to packages in general. We've done some incremental fixup over time as parts of the tooling were modified, but there are still random references to "plugin" where we actually mean "package", which can be confusing to maintainers of the code (and in the case of the
publish-plugincommand, andlisttypes, to tool clients).This is the result of auditing references to "plugin" and fixing the ones that were incorrect.
(It is still the case that most tests use
createFakePluginwhen they could use the newercreateFakePackage; I fixed a few of those but then realized that the change would be enormous if I continued, and those are pretty harmless, so I left the rest.)Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).