[go: nahoru, domu]
Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[various] Remove unused Gradle files #6623

Merged
merged 1 commit into from
Oct 26, 2022
Merged

[various] Remove unused Gradle files #6623

merged 1 commit into from
Oct 26, 2022

Conversation

stuartmorgan
Copy link
Contributor

Removes gradle-wrapper.properties from non-example portions of packages, since it's not used in that context.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan
[various] Remove unused Gradle files
702e6cc 
Removes `gradle-wrapper.properties` from non-example portions of
packages, since it's not used in that context.
@stuartmorgan
Copy link
Contributor Author

I found a few of these while looking for files that still had old Gradle versions, and was going to update them, but then realized they were already so out of sync with the package's AGP version that it should have been broken already, which made me suspicious. Most of our plugins don't have this file, and a new-from-template plugin doesn't have it either, so it looks like we just had these by accident.

@stuartmorgan stuartmorgan added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Oct 26, 2022
@stuartmorgan
Copy link
Contributor Author

Overrides: removing unused cruft doesn't need to be versioned or even noted, since absolutely nobody should be affected.

camsim99
camsim99 approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor
@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 26, 2022
@auto-submit auto-submit bot merged commit 1459767 into flutter:main Oct 26, 2022
@stuartmorgan stuartmorgan deleted the gradle-cruft-cleanup branch October 26, 2022 20:00
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 27, 2022
@engine-flutter-autoroll
145976792 [various] Remove unused Gradle files (flutter/plugins#6623)
af142e8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 27, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 27, 2022
@engine-flutter-autoroll
145976792 [various] Remove unused Gradle files (flutter/plugins#6623)
8928f52
adam-harwood pushed a commit to adam-harwood/flutter_plugins that referenced this pull request Nov 3, 2022
@stuartmorgan
[various] Remove unused Gradle files (flutter#6623)
04aa93e
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@stuartmorgan @mauricioluz
[various] Remove unused Gradle files (flutter#6623)
7c33316
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@camsim99 camsim99 camsim99 approved these changes

@GaryQian GaryQian Awaiting requested review from GaryQian

@tarrinneal tarrinneal Awaiting requested review from tarrinneal

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: espresso p: flutter_plugin_android_lifecycle p: in_app_purchase p: shared_preferences p: video_player platform-android
Projects
None yet
Milestone
No milestone
2 participants
@stuartmorgan @camsim99