-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[ci] Improve analysis_options alignment with flutter/packages #6728
[ci] Improve analysis_options alignment with flutter/packages #6728
Conversation
This pulled in a ton of people due to CODEOWNERS, but it just needs one review from whoever gets to it since the actual plugin changes are trivial and mechanical. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a question
@@ -1664,7 +1664,7 @@ void main() { | |||
'with notFound error ' | |||
'if the camera does not exist', (WidgetTester tester) async { | |||
expect( | |||
() async => await CameraPlatform.instance.getMaxZoomLevel( | |||
() async => CameraPlatform.instance.getMaxZoomLevel( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is await optional here? are these functions still async?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is still async; see https://dart-lang.github.io/linter/lints/unnecessary_await_in_return.html for a full example of the lint that these changes are fixing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fascinating!
* 9990a4b1d [ci] Improve analysis_options alignment with flutter/packages (flutter/plugins#6728) * 7abe5a79c Roll Flutter from 633d7ef to 2962228 (13 revisions) (flutter/plugins#6730) * 5d847ef39 [sign_in]: Bump play-services-auth from 20.3.0 to 20.4.0 in /packages/google_sign_in/google_sign_in_android/android (flutter/plugins#6726)
…#115837) * 9990a4b1d [ci] Improve analysis_options alignment with flutter/packages (flutter/plugins#6728) * 7abe5a79c Roll Flutter from 633d7ef to 2962228 (13 revisions) (flutter/plugins#6730) * 5d847ef39 [sign_in]: Bump play-services-auth from 20.3.0 to 20.4.0 in /packages/google_sign_in/google_sign_in_android/android (flutter/plugins#6726)
…#115837) * 9990a4b1d [ci] Improve analysis_options alignment with flutter/packages (flutter/plugins#6728) * 7abe5a79c Roll Flutter from 633d7ef to 2962228 (13 revisions) (flutter/plugins#6730) * 5d847ef39 [sign_in]: Bump play-services-auth from 20.3.0 to 20.4.0 in /packages/google_sign_in/google_sign_in_android/android (flutter/plugins#6726)
…r#6728) * Add more options that are in flutter/packages * Fix unnecessary awaits * More option alignment * Add and locally supress avoid_implementing_value_types * Fix release-info for test-only changes * Fix update-release-info handling of 'minimal' * Update release metadata
Updates analysis options to reduce diff from flutter/packages (which also means reducing diff from flutter/flutter since that repo had a more recent re-alignment). The only code changes needed (other than a handful of local ignores of new options) was to remove a lot of unnecessary awaits in returns.
This also includes a small fix to the way the repo tooling's
update-release-info
works to avoid unnecessary CHANGELOG updates when run against this PR (flutter/flutter#113941).Part of flutter/flutter#76229 and flutter/flutter#113764
Fixes flutter/flutter#113941
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).