This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[ci] Improve analysis_options alignment with flutter/packages #6728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pulled in a ton of people due to CODEOWNERS, but it just needs one review from whoever gets to it since the actual plugin changes are trivial and mechanical. |
hellohuanlin
approved these changes
Nov 21, 2022
| @@ -1664,7 +1664,7 @@ void main() { | |||
| 'with notFound error ' | |||
| 'if the camera does not exist', (WidgetTester tester) async { | |||
| expect( | |||
| () async => await CameraPlatform.instance.getMaxZoomLevel( | |||
| () async => CameraPlatform.instance.getMaxZoomLevel( | |||
There was a problem hiding this comment.
is await optional here? are these functions still async?
There was a problem hiding this comment.
Everything is still async; see https://dart-lang.github.io/linter/lints/unnecessary_await_in_return.html for a full example of the lint that these changes are fixing.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 22, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 22, 2022
* 9990a4b1d [ci] Improve analysis_options alignment with flutter/packages (flutter/plugins#6728) * 7abe5a79c Roll Flutter from 633d7ef to 2962228 (13 revisions) (flutter/plugins#6730) * 5d847ef39 [sign_in]: Bump play-services-auth from 20.3.0 to 20.4.0 in /packages/google_sign_in/google_sign_in_android/android (flutter/plugins#6726)
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…#115837) * 9990a4b1d [ci] Improve analysis_options alignment with flutter/packages (flutter/plugins#6728) * 7abe5a79c Roll Flutter from 633d7ef to 2962228 (13 revisions) (flutter/plugins#6730) * 5d847ef39 [sign_in]: Bump play-services-auth from 20.3.0 to 20.4.0 in /packages/google_sign_in/google_sign_in_android/android (flutter/plugins#6726)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…#115837) * 9990a4b1d [ci] Improve analysis_options alignment with flutter/packages (flutter/plugins#6728) * 7abe5a79c Roll Flutter from 633d7ef to 2962228 (13 revisions) (flutter/plugins#6730) * 5d847ef39 [sign_in]: Bump play-services-auth from 20.3.0 to 20.4.0 in /packages/google_sign_in/google_sign_in_android/android (flutter/plugins#6726)
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
…r#6728) * Add more options that are in flutter/packages * Fix unnecessary awaits * More option alignment * Add and locally supress avoid_implementing_value_types * Fix release-info for test-only changes * Fix update-release-info handling of 'minimal' * Update release metadata
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates analysis options to reduce diff from flutter/packages (which also means reducing diff from flutter/flutter since that repo had a more recent re-alignment). The only code changes needed (other than a handful of local ignores of new options) was to remove a lot of unnecessary awaits in returns.
This also includes a small fix to the way the repo tooling's
update-release-infoworks to avoid unnecessary CHANGELOG updates when run against this PR (flutter/flutter#113941).Part of flutter/flutter#76229 and flutter/flutter#113764
Fixes flutter/flutter#113941
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).