This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[path_provider] Remove unused Guava dependency #6744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
josh88versa
pushed a commit
to versa-asia/plugins
that referenced
this pull request
Nov 23, 2022
* Remove unused Guava dependency * Metadata * Update Nullable import
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 23, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 23, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 23, 2022
* 2a5239495 [ci] Import flutter/packages install_chromium.sh (flutter/plugins#6727) * e484dec84 Switch `ios_platform_tests` from Cirrus to LUCI (flutter/plugins#6729) * fb0a593d6 Roll Flutter from 2962228 to 06d90b8 (17 revisions) (flutter/plugins#6742) * dd493f5b1 [path_provider] Remove unused Guava dependency (flutter/plugins#6744) * b2d4ee5ce [google_sign_in] Roll Guava dependency to 31.1 (flutter/plugins#6746) * be855018f [ios_platform_images] remove deprecated APIs (flutter/plugins#6693) * a431b35bf Roll Flutter from 06d90b8 to 0eb2d51 (17 revisions) (flutter/plugins#6750)
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…#115930) * 2a5239495 [ci] Import flutter/packages install_chromium.sh (flutter/plugins#6727) * e484dec84 Switch `ios_platform_tests` from Cirrus to LUCI (flutter/plugins#6729) * fb0a593d6 Roll Flutter from 2962228 to 06d90b8 (17 revisions) (flutter/plugins#6742) * dd493f5b1 [path_provider] Remove unused Guava dependency (flutter/plugins#6744) * b2d4ee5ce [google_sign_in] Roll Guava dependency to 31.1 (flutter/plugins#6746) * be855018f [ios_platform_images] remove deprecated APIs (flutter/plugins#6693) * a431b35bf Roll Flutter from 06d90b8 to 0eb2d51 (17 revisions) (flutter/plugins#6750)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…#115930) * 2a5239495 [ci] Import flutter/packages install_chromium.sh (flutter/plugins#6727) * e484dec84 Switch `ios_platform_tests` from Cirrus to LUCI (flutter/plugins#6729) * fb0a593d6 Roll Flutter from 2962228 to 06d90b8 (17 revisions) (flutter/plugins#6742) * dd493f5b1 [path_provider] Remove unused Guava dependency (flutter/plugins#6744) * b2d4ee5ce [google_sign_in] Roll Guava dependency to 31.1 (flutter/plugins#6746) * be855018f [ios_platform_images] remove deprecated APIs (flutter/plugins#6693) * a431b35bf Roll Flutter from 06d90b8 to 0eb2d51 (17 revisions) (flutter/plugins#6750)
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
* Remove unused Guava dependency * Metadata * Update Nullable import
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last necessary use of Guava in the plugin was removed in #5959, but the dependency itself wasn't removed; this cleans up the unnecessary dependency (replacing the Guava-sourced
Nullabilityannotation with the version fromandroidx.annotations, which we are already importing).Fixes flutter/flutter#115462
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).