-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[path_provider] Remove unused Guava dependency #6744
[path_provider] Remove unused Guava dependency #6744
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
* Remove unused Guava dependency * Metadata * Update Nullable import
* 2a5239495 [ci] Import flutter/packages install_chromium.sh (flutter/plugins#6727) * e484dec84 Switch `ios_platform_tests` from Cirrus to LUCI (flutter/plugins#6729) * fb0a593d6 Roll Flutter from 2962228 to 06d90b8 (17 revisions) (flutter/plugins#6742) * dd493f5b1 [path_provider] Remove unused Guava dependency (flutter/plugins#6744) * b2d4ee5ce [google_sign_in] Roll Guava dependency to 31.1 (flutter/plugins#6746) * be855018f [ios_platform_images] remove deprecated APIs (flutter/plugins#6693) * a431b35bf Roll Flutter from 06d90b8 to 0eb2d51 (17 revisions) (flutter/plugins#6750)
…#115930) * 2a5239495 [ci] Import flutter/packages install_chromium.sh (flutter/plugins#6727) * e484dec84 Switch `ios_platform_tests` from Cirrus to LUCI (flutter/plugins#6729) * fb0a593d6 Roll Flutter from 2962228 to 06d90b8 (17 revisions) (flutter/plugins#6742) * dd493f5b1 [path_provider] Remove unused Guava dependency (flutter/plugins#6744) * b2d4ee5ce [google_sign_in] Roll Guava dependency to 31.1 (flutter/plugins#6746) * be855018f [ios_platform_images] remove deprecated APIs (flutter/plugins#6693) * a431b35bf Roll Flutter from 06d90b8 to 0eb2d51 (17 revisions) (flutter/plugins#6750)
…#115930) * 2a5239495 [ci] Import flutter/packages install_chromium.sh (flutter/plugins#6727) * e484dec84 Switch `ios_platform_tests` from Cirrus to LUCI (flutter/plugins#6729) * fb0a593d6 Roll Flutter from 2962228 to 06d90b8 (17 revisions) (flutter/plugins#6742) * dd493f5b1 [path_provider] Remove unused Guava dependency (flutter/plugins#6744) * b2d4ee5ce [google_sign_in] Roll Guava dependency to 31.1 (flutter/plugins#6746) * be855018f [ios_platform_images] remove deprecated APIs (flutter/plugins#6693) * a431b35bf Roll Flutter from 06d90b8 to 0eb2d51 (17 revisions) (flutter/plugins#6750)
* Remove unused Guava dependency * Metadata * Update Nullable import
The last necessary use of Guava in the plugin was removed in #5959, but the dependency itself wasn't removed; this cleans up the unnecessary dependency (replacing the Guava-sourced
Nullability
annotation with the version fromandroidx.annotations
, which we are already importing).Fixes flutter/flutter#115462
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).