This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[ci] Fix macOS LUCI merge base #6798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the repo tooling relies on `FETCH_HEAD` being set to `origin/main` in CI, which is done in `prepare_tool.sh` for LUCI bots. Longer term we should restructure the CI scripts to be explicit about the base SHA instead of relying on `FETCH_HEAD`, but for now this adds the missing `prepare_tool.sh` step to the new iOS LUCI tests so that they compute diffs correctly. Fixes flutter/flutter#116448
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 7, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 7, 2022
* 610370eb6 Revert "[camera] Add ability to concurrently record and stream video (#6290)" (flutter/plugins#6796) * 36526ee23 [ci] Fix macOS LUCI merge base (flutter/plugins#6798) * 7b5d8323e Roll Flutter from 30fc993 to e2fb672 (25 revisions) (flutter/plugins#6802)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…#116660) * 610370eb6 Revert "[camera] Add ability to concurrently record and stream video (flutter#6290)" (flutter/plugins#6796) * 36526ee23 [ci] Fix macOS LUCI merge base (flutter/plugins#6798) * 7b5d8323e Roll Flutter from 30fc993 to e2fb672 (25 revisions) (flutter/plugins#6802)
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
Currently the repo tooling relies on `FETCH_HEAD` being set to `origin/main` in CI, which is done in `prepare_tool.sh` for LUCI bots. Longer term we should restructure the CI scripts to be explicit about the base SHA instead of relying on `FETCH_HEAD`, but for now this adds the missing `prepare_tool.sh` step to the new iOS LUCI tests so that they compute diffs correctly. Fixes flutter/flutter#116448
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the repo tooling relies on
FETCH_HEADbeing set toorigin/mainin CI, which is supposed to be done inprepare_tool.shfor LUCI bots. Longer term we should restructure the CI scripts to be explicit about the base SHA instead of relying onFETCH_HEAD, but for now this adds the missingprepare_tool.shstep to the new iOS LUCI tests so that they compute diffs correctly.Fixes flutter/flutter#116448