This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[various] Enable avoid_print #6842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables the `avoid_print` lint, and fixes violations (mostly by opting example files out of it).
|
Not all of these version bumps are necessary (the tooling doesn't do line-by-line analysis yet, so doesn't know when it's just changing |
GaryQian
approved these changes
Dec 14, 2022
packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md
Outdated
Show resolved
Hide resolved
hellohuanlin
approved these changes
Dec 14, 2022
jmagman
reviewed
Dec 14, 2022
|
Based on the review comments, I've gone back and removed almost all of the version bumps. In some cases that means that the Example tab on pub.dev will be slightly out of sync with the actual example code in the repo until the next actual change, but it seems like the consensus is that since there are just either adding an This leaves version changes for:
|
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 15, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 15, 2022
* 00b77e4cc Roll Flutter from 15af817 to 028c6e2 (13 revisions) (flutter/plugins#6843) * b2cdcb69a [camera_android_camerax] `unnecessary_parenthesis` lint fix (flutter/plugins#6841) * 3a093e49b [various] Enable avoid_print (flutter/plugins#6842) * 78de28ca2 [webview_flutter_platform_interface] Updates platform interface to new interface (flutter/plugins#6846)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…#117145) * 00b77e4cc Roll Flutter from 15af817 to 028c6e2 (13 revisions) (flutter/plugins#6843) * b2cdcb69a [camera_android_camerax] `unnecessary_parenthesis` lint fix (flutter/plugins#6841) * 3a093e49b [various] Enable avoid_print (flutter/plugins#6842) * 78de28ca2 [webview_flutter_platform_interface] Updates platform interface to new interface (flutter/plugins#6846)
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
* [various] Enable avoid_print Enables the `avoid_print` lint, and fixes violations (mostly by opting example files out of it). * Version bumps * Add tooling analysis option file that was accidentally omitted * Fix typo in analysis_options found by adding tool sub-options * Revert most version bumps * Fix ios_platform_images
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the
avoid_printlint, and fixes violations (mostly by opting example files out of it).Also fixes a typo in the analysis file that wasn't noticed until adding
script/tool/analysis_options.yaml, and makes minor (test/example-only) updates to actually fix that option now that it's really enabled.Part of flutter/flutter#76229 and flutter/flutter#113764
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).