This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[cameraX] Add integration test for availableCameras #7156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can see the test run here: https://cirrus-ci.com/task/6371682802204672?logs=firebase_test_lab#L0 |
|
LGTM! Glad to see a test run succeeding :) |
gmackall
approved these changes
Feb 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 15, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 15, 2023
* 66d5724fa Revert "[camera] flip/change camera while recording (split out PR for cam_avfoundation and cam_android) (#7109)" (flutter/plugins#7181) * d2fba3822 [webview_flutter_android][webview_flutter_wkwebview] Adds support to retrieve native `WebView` (flutter/plugins#7071) * 7a7e43e79 [google_maps_flutter_android] Fixes initial padding not working while map has not been created yet. (flutter/plugins#7135) * 677b43ad9 [ci] Remove repo tooling (flutter/plugins#7172) * 2ce625f1a [cameraX] Add integration test for availableCameras (flutter/plugins#7156)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds integration test for the
availableCameras()method in the plugin. Part of flutter/flutter#119379.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).