[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS add-to-app instructions are missing caveat that static FlutterPluginRegistrant should be linked against, but not embedded #10707

Closed
jmagman opened this issue Jun 4, 2024 · 3 comments
Closed

iOS add-to-app instructions are missing caveat that static FlutterPluginRegistrant should be linked against, but not embedded #10707

jmagman opened this issue Jun 4, 2024 · 3 comments
Assignees
@atsansone
Labels
devos.macOS Relates to developing apps on macOS platform e1-hours Effort: < 8 hrs p2-medium Necessary but not urgent concern. Resolve when possible. st.triage.ltw Indicates Lead Tech Writer has triaged t.add-to-app Relates to adding Flutter components to native app target.iOS Target apps on the iOS Platform

Comments

@jmagman
Copy link
Member
jmagman commented Jun 4, 2024 •
edited
Loading

During iOS add-to-app the static FlutterPluginRegistrant.xcframework should be linked against, but not embedded, or it app will have archive/App Store validation failures. We just received a report from a customer that they were getting App Store submission errors due to this problem.

I added this warning in #3544, but it since looks like it was removed.

For example, you can drag the frameworks (except for FlutterPluginRegistrant and any other static frameworks) from your application's Frameworks group into your targets' build settings > Build Phases > Embed Frameworks. Then, select "Embed & Sign" from the drop-down list.

The FlutterPluginRegistrant should be specifically called out in https://docs.flutter.dev/add-to-app/ios/project-setup#embed-the-frameworks.
@jmagman jmagman changed the title iOS add-to-app instructions are missing caveat that static FlutterPluginRegistrant should be linked on, but not embedded. iOS add-to-app instructions are missing caveat that static FlutterPluginRegistrant should be linked on, but not embedded Jun 4, 2024
@jmagman
Copy link
Member Author
jmagman commented Jun 4, 2024

cc @atsansone who is editing these instructions now.

@jmagman jmagman changed the title iOS add-to-app instructions are missing caveat that static FlutterPluginRegistrant should be linked on, but not embedded iOS add-to-app instructions are missing caveat that static FlutterPluginRegistrant should be linked against, but not embedded Jun 4, 2024
@atsansone atsansone self-assigned this Jun 5, 2024
@atsansone atsansone added p2-medium Necessary but not urgent concern. Resolve when possible. e1-hours Effort: < 8 hrs devos.macOS Relates to developing apps on macOS platform target.iOS Target apps on the iOS Platform t.add-to-app Relates to adding Flutter components to native app st.triage.ltw Indicates Lead Tech Writer has triaged labels Jun 5, 2024
@atsansone
Copy link
Contributor

Adding this to PR #10699

@jmagman jmagman mentioned this issue Jun 14, 2024
Merged
atsansone added a commit to atsansone/website that referenced this issue Jun 14, 2024
@atsansone
Fix flutter#10707
5ddc1cc
@atsansone
Copy link
Contributor

Fixed in #10699

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atsansone atsansone

Labels
devos.macOS Relates to developing apps on macOS platform e1-hours Effort: < 8 hrs p2-medium Necessary but not urgent concern. Resolve when possible. st.triage.ltw Indicates Lead Tech Writer has triaged t.add-to-app Relates to adding Flutter components to native app target.iOS Target apps on the iOS Platform
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmagman @atsansone