[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Add migration documentation to handle API 35 edge-to-edge changes #10755

Open
camsim99 opened this issue Jun 17, 2024 · 5 comments
Open
Assignees
Labels
a.rn.breaking-changes Relates to breaking changes on a Flutter release e2-days Effort: < 5 days p2-medium Necessary but not urgent concern. Resolve when possible. target.Android Target apps on the Android Platform

Comments

@camsim99
Copy link
Contributor

According to Android 35 docs, once an Android app targets API 35, edge to edge will become the default layout mode and there are several changes coming to edge-to-edge, most notably for Flutter the coloring of the system (status and navigation) bars. In order to support Flutter apps that target API 35 and edge-to-edge mode more generally as we plan to make this the default mode on Android (see flutter/flutter#86248), we need to develop migration documentation on how to modify one's Flutter app to adopt edge-to-edge mode.

@sfshaza2 sfshaza2 added p1-high Major but not urgent concern: Resolve in months. Update each month. e2-days Effort: < 5 days labels Jun 20, 2024
@sfshaza2 sfshaza2 self-assigned this Jun 21, 2024
@atsansone atsansone added the target.Android Target apps on the Android Platform label Jun 25, 2024
@sfshaza2 sfshaza2 added p2-medium Necessary but not urgent concern. Resolve when possible. and removed p1-high Major but not urgent concern: Resolve in months. Update each month. labels Jun 26, 2024
@sfshaza2 sfshaza2 assigned camsim99 and unassigned sfshaza2 Jun 26, 2024
@sfshaza2
Copy link
Contributor

I spoke offline to Camille. This is needed for the Q4 release, not Q3. I've asked her, when the time comes, to publish a public design doc and a breaking change page.

@parlough parlough added the a.rn.breaking-changes Relates to breaking changes on a Flutter release label Jun 26, 2024
@camsim99
Copy link
Contributor Author
camsim99 commented Jul 1, 2024

To clarify (I'm not clear on how this aligns with the release schedule), I plan to do this work in Q3 and will publish the breaking change page in Q4.

@camsim99
Copy link
Contributor Author
camsim99 commented Aug 7, 2024

@sfshaza2 Going to start working on migration docs soon (not the breaking change documentation as we have not made that change yet), which will tell developers either how to opt out of edge to edge themselves or (if I can't make this work myself in the next week) tell developers how to migrate to edge to edge. Where on the website would be an appropriate place to put this documentation?

@camsim99
Copy link
Contributor Author

Decided to split this into two parts:

  1. Write a guide on how to opt out of edge to edge by default
  2. Write a guide on how to adopt edge to edge as a follow up to the first guide (the first guide is more of a temporary workaround and the second will give a long term solution)

@sfshaza2
Copy link
Contributor

SG!

camsim99 added a commit that referenced this issue Sep 3, 2024
…11068)

_Description of what this PR is changing or adding, and why:_
Adds a migration guide telling folks how to opt out of edge-to-edge mode
when their Flutter on Android app targets Android 15+.

This (targeting Android 15+) will happen by default in the next Flutter
stable version, so the described migration steps will be necessary if
folks do not explicitly use edge-to-edge mode in their app. Folks may
also change the Android version they target, so the steps apply if their
target Android 15+ themselves, as well.

_Issues fixed by this PR (if any):_
Part of #10755

_PRs or commits this PR depends on (if any):_
flutter/flutter#153795 (merged)

## Presubmit checklist

- [x] This PR is marked as draft with an explanation if not meant to
land until a future stable release.
- [x] This PR doesn’t contain automatically generated corrections
(Grammarly or similar).
- [x] This PR follows the [Google Developer Documentation Style
Guidelines](https://developers.google.com/style) — for example, it
doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person).
- [x] This PR uses [semantic line
breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks)
of 80 characters or fewer.

---------

Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a.rn.breaking-changes Relates to breaking changes on a Flutter release e2-days Effort: < 5 days p2-medium Necessary but not urgent concern. Resolve when possible. target.Android Target apps on the Android Platform
Projects
None yet
Development

No branches or pull requests

4 participants