[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc updates to navbar and homepage #1421

Merged
merged 1 commit into from
Oct 10, 2018
Merged

Misc updates to navbar and homepage #1421

merged 1 commit into from
Oct 10, 2018

Conversation

fertolg
Copy link
Contributor
@fertolg fertolg commented Oct 9, 2018
  • Navbar updates:
    • Updated brand lockup
    • Adds Get Started button to homepage navbar
    • Increases hamburger icon to 28px
    • Updates social links so they are always present on navbar
  • Homepage updates:
    • Embedded Youtube video plays with subtitles by default
    • Tweaked partners logo sizes and padding
    • Updates copy and some links

Misc updates to navbar and homepage
67a3a5c 
- Navbar updates:
  - Updated brand lockup
  - Adds Get Started button to homepage navbar
  - Increases hamburger icon to 28px
  - Updates social links so they are always present on navbar
- Homepage updates:
  - Embedded Youtube video plays with subtitles by default
  - Tweaked partners logo sizes and padding
  - Updates copy and some links
@fertolg fertolg requested review from chalin and Sfshaza October 9, 2018 23:18
@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label Oct 9, 2018
@fertolg
Copy link
Contributor Author
fertolg commented Oct 9, 2018

@chalin: This PR includes some updates from our meeting this morning, as well as some updates Martin requested during our walkthrough today.

@fertolg
Copy link
Contributor Author
fertolg commented Oct 9, 2018

Hmmm the build failed but the error doesn't seem to be in my changes, I think it's an issue with some .dart code?

@chalin
Copy link
Contributor
chalin commented Oct 10, 2018

Hmmm the build failed but the error doesn't seem to be in my changes, I think it's an issue with some .dart code?

Yes. Issue details are in #1423, and a workaround submitted via #1424.

chalin
chalin approved these changes Oct 10, 2018
View reviewed changes
Copy link
Contributor
@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I thought that we decided that the Get started button would appear only on the showcase page (right @filiph @Sfshaza)? Have you heard otherwise?
  • The Flutter lockups have .svg file extensions but essentially they are images. I much prefer that we either get a true SVG (or, if we can only get an image, then use an appropriately rendered, say, PNG).
  • .btn-cta font is too small (for wide displays) IMHO

@fertolg
Copy link
Contributor Author
fertolg commented Oct 10, 2018

During our review with Martin yesterday, he asked the get started button was shown in homepage and in showcases page because the get started button in the first content card won't be visible at load time once the hero image is in.

You are correct, the flutter logo and word mark are raster images for some reason, but the 'by Google' is a vector outline. I'll ask Daniel to see if he has the original vector outline for the flutter logo and word mark.

@fertolg fertolg merged commit d3dd4af into dash Oct 10, 2018
@fertolg fertolg deleted the misc-updates branch October 10, 2018 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin approved these changes

@Sfshaza Sfshaza Awaiting requested review from Sfshaza

Assignees
No one assigned
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fertolg @chalin @googlebot