Gut /docs/catalog/samples #1924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And remove its link from the sidenav.
chalin
approved these changes
Dec 6, 2018
|
Yes, we did.
…On Thu, Dec 6, 2018 at 5:14 PM Patrice Chalin ***@***.***> wrote:
***@***.**** approved this pull request.
I think that we originally wanted to keep the old samples page (and its
content), and just add a warning and a link to the sample repo, but this
actually seems better to me.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1924 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AqXHqRPHTegoG8vW-VvCWOJTb8WT0qfSks5u2VBqgaJpZM4ZG7lV>
.
|
|
I think that originally we wanted a samples page so that it would act as a target for redirects. In PR keeps the page (for redirects), but instead correctly directs folks to the samples repo. Is that ok @sfshaza2? |
|
Good plan, thanks. |
|
sgtm. Thanks, Tao.
…On Thu, Dec 6, 2018 at 8:50 PM Patrice Chalin ***@***.***> wrote:
Good plan, thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1924 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AqXHqaeWlss3W07tN9CRqO1F_CXALho4ks5u2YMlgaJpZM4ZG7lV>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And remove its link from the sidenav.
Staged: https://kw-flutter-1.firebaseapp.com/docs/catalog/samples
Fixes #1198.
/cc @RedBrogdon @sfshaza2