Rename Form Widgets for Clarity #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, Brian! It's much easier to read given the added length. |
|
Looks good to me. Just what happens when things are names similar things. Plus it's always hard to tell what is a name required by the framework and what is a custom one. Comment definitely helps to at least find the problem faster. |
|
I absolutely agree! I really need "readonly" feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to address this issue: flutter/flutter#18304
Users reading the docs were using
GlobalKey<MyFormState>instead ofGlobalKey<FormState>. It's an easy mistake to make, sinceMyFormStateandFormStatelook quite similar.I've changed
MyFormStatetoMyCustomFormStateto hopefully make the two classes more distinct from one another, and added a note to the reader: You must useGlobalKey<FormState>.Please let me know if you think this will help address the issue, or if you can think of something better :)