[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified "add flutter to path"'s bash instructions to work for non-login shells. #10781

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Conversation

Aron-Lomner
Copy link
Contributor

Description of what this PR is changing or adding, and why:
The current bash instruction only works with login-shells or SSH.

Issues fixed by this PR (if any):
#10778

PRs or commits this PR depends on (if any):

Presubmit checklist

  • [x ] This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • [ x] This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • [ x] This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • [ x] This PR uses semantic line breaks of 80 characters or fewer.

…gin shells.

fix Bash add Flutter to  path instructions are incorrect for some scenarios. #10778
Copy link
google-cla bot commented Jun 21, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor
@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified the comment to follow our structural conventions. Otherwise lgtm

@sfshaza2
Copy link
Contributor

Also, please sign the CLA, @Aron-Lomner, so I can land!

/gcbrun

@flutter-website-bot
Copy link
Collaborator
flutter-website-bot commented Jun 21, 2024

Visit the preview URL for this PR (updated for commit 69cb617):

https://flutter-docs-prod--pr10781-main-v862d6f1.web.app

Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
@sfshaza2
Copy link
Contributor

/gcbrun

@sfshaza2 sfshaza2 merged commit a951b41 into flutter:main Jun 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants