Fix staggered animation page #10809
Fix staggered animation page #10809
Conversation
|
Visit the preview URL for this PR (updated for commit 69df676): https://flutter-docs-prod--pr10809-fix-5792-6lfeljrw.web.app |
|
PLEASE, add a sentence in addition to a bug link. It's a much more efficient use of the reviewer's time. |
|
|
||
| When the controlling animation's value changes, | ||
| the new animation's value changes, triggering the UI to update. | ||
|
|
||
| ### Tween a widget's width |
There was a problem hiding this comment.
Rephrase; Tween is not a verb.
There was a problem hiding this comment.
In the animation business, it is: https://en.wikipedia.org/wiki/Inbetweening.
There was a problem hiding this comment.
Perhaps "Interpolate" or "Transition" would read better when a verb is needed? That would avoid conflation with "tween" as the type (or instance of that type), and potentially allow better machine translation too.
"Interpolate between a widget's widths" or "Transition between a widget's widths"
There was a problem hiding this comment.
Yes, to either of Parker's suggestions.
|
|
||
| To review other available pre-defined animation curves, consult [`Curves`][]. | ||
|
|
||
| ### Tween a widget's border radius |
There was a problem hiding this comment.
Again, don't use "Tween" as a verb.
| The following code builds the tween for the `borderRadius` property | ||
| (which controls the roundness of the square's corners), | ||
| using `BorderRadius.circular()`. | ||
|
|
||
| ```dart | ||
| ```dart title="Tweening the widget's corners (main.dart)" |
Agreed and fixed. |
|
|
||
| ```dart | ||
| ```dart title="Tweening the widget's width (main.dart)" |
There was a problem hiding this comment.
The titles on code blocks aren't really meant for descriptions but rather filenames. Is the title necessary here?
|
|
||
| When the controlling animation's value changes, | ||
| the new animation's value changes, triggering the UI to update. | ||
|
|
||
| ### Tween a widget's width |
There was a problem hiding this comment.
Perhaps "Interpolate" or "Transition" would read better when a verb is needed? That would avoid conflation with "tween" as the type (or instance of that type), and potentially allow better machine translation too.
"Interpolate between a widget's widths" or "Transition between a widget's widths"
Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
staggered_pic_selectionvideo to 'Staggered animations' page #5792