[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch simple state management page to provider #2686

Merged
merged 2 commits into from
May 22, 2019
Merged

Switch simple state management page to provider #2686

merged 2 commits into from
May 22, 2019

Conversation

filiph
Copy link
Contributor
@filiph filiph commented May 22, 2019

This is switching the example from ScopedModel to Provider.

@filiph
Switch simple state management page to provider
e2fddaa 
This is switching the example from ScopedModel to Provider.
@filiph filiph requested a review from sfshaza2 May 22, 2019 01:35
@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label May 22, 2019
@filiph
Copy link
Contributor Author
filiph commented May 22, 2019

Staged: https://flutter-website-filiph-staging.firebaseapp.com/docs/development/data-and-backend/state-mgmt/simple

This is, in large part, a search/replace. ScopedModel and Provider are very similar. That said, there were some paragraphs I had to change, and I'd love to have that reviewed.

sfshaza2
sfshaza2 approved these changes May 22, 2019
View reviewed changes
Copy link
Contributor
@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for updating to the provider package!

@filiph filiph merged commit 729a505 into flutter:master May 22, 2019
@filiph filiph deleted the scopedmodel-to-provider branch May 22, 2019 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfshaza2 sfshaza2 sfshaza2 approved these changes

Assignees
No one assigned
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@filiph @sfshaza2 @googlebot