[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the step by step to the same file name #2799

Merged
merged 1 commit into from
Jul 2, 2019

Conversation

soonsam123
Copy link
Contributor

Doesn't make more sense to keep using my_icon for the file name since we are following a step by step?

Doesn't make more sense to keep using `my_icon` for the file name since we are following a step by step?
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Contributor has not signed the Contributor License Agreement label Jul 2, 2019
@soonsam123
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Contributor has signed the Contributor License Agreement and removed cla: no Contributor has not signed the Contributor License Agreement labels Jul 2, 2019
Copy link
Contributor
@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. LGTM

@sfshaza2 sfshaza2 merged commit 421e39a into flutter:master Jul 2, 2019
matthew-carroll pushed a commit to matthew-carroll/website that referenced this pull request Jul 11, 2019
Doesn't make more sense to keep using `my_icon` for the file name since we are following a step by step?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants