[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update simple state management sample to provider 3.0 #2810

Merged
merged 2 commits into from
Jul 9, 2019
Merged

Update simple state management sample to provider 3.0 #2810

merged 2 commits into from
Jul 9, 2019

Conversation

filiph
Copy link
Contributor
@filiph filiph commented Jul 8, 2019

No description provided.

@filiph filiph requested a review from sfshaza2 July 8, 2019 17:54
@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label Jul 8, 2019
@filiph filiph mentioned this pull request Jul 8, 2019
Closed
@filiph
Copy link
Contributor Author
filiph commented Jul 8, 2019

Fixes #2808.

sfshaza2
sfshaza2 approved these changes Jul 8, 2019
View reviewed changes
Copy link
Contributor
@sfshaza2 sfshaza2 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for updating the provider package version number. The build is broken with bad links, which must have changed. Would you mind fixing in this PR? (See next note…)

@sfshaza2
Copy link
Contributor
sfshaza2 commented Jul 8, 2019

Regarding the broken links. Can you fix?

In /docs/cookbook/forms/focus:
Correct link: https://api.flutter.dev/flutter/widgets/FocusNode/requestFocus.html, SO
{{site.api}}/flutter/widgets/FocusNode/requestFocus.html
Bad link: https://api.flutter.dev/flutter/widgets/FocusScopeNode/requestFocus.html

In /docs/development/platform-integration/platform-channels: (not sure about this one…)
Correct link: https://api.flutter.dev/javadoc/io/flutter/plugin/common/MethodChannel.html (I THINK), SO
{{site.api}}/javadoc/io/flutter/plugin/common/MethodChannel.html
Bad link: https://api.flutter.dev/objcdoc/Classes/FlutterMethodChannel.html

@sfshaza2
Copy link
Contributor
sfshaza2 commented Jul 9, 2019

I’m going to go ahead and merge, and we can take care of the links in another PR.

@sfshaza2 sfshaza2 merged commit f1d64a9 into flutter:master Jul 9, 2019
@filiph filiph deleted the provider-3 branch July 10, 2019 04:31
matthew-carroll pushed a commit to matthew-carroll/website that referenced this pull request Jul 11, 2019
@filiph @matthew-carroll
Update simple state management sample to provider 3.0 (flutter#2810)
a4c150e 
* Update simple state management sample to provider 3.0

* Conform to added copyright notices
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfshaza2 sfshaza2 sfshaza2 approved these changes

Assignees
No one assigned
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@filiph @sfshaza2 @googlebot