[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interactive tutorial copyedits and use of code-excerpts #2264

Merged
merged 4 commits into from
Jan 25, 2019
Merged

Interactive tutorial copyedits and use of code-excerpts #2264

merged 4 commits into from
Jan 25, 2019

Conversation

chalin
Copy link
Contributor
@chalin chalin commented Jan 24, 2019

@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label Jan 24, 2019
@chalin chalin requested a review from kwalrath January 24, 2019 18:13
chalin added a commit that referenced this pull request Jan 24, 2019
@chalin
Add examples/layout/lakes/interactive code
3a45982 
I'm committing this first so that CI tests for #2264 can pass (external link checking will fail if the sources aren't in the repo).
@chalin chalin mentioned this pull request Jan 24, 2019
Merged
chalin added a commit that referenced this pull request Jan 24, 2019
@chalin
Add examples/layout/lakes/interactive code (#2267)
7953e2b 
I'm committing this first so that CI tests for #2264 can pass (external link checking will fail if the sources aren't in the repo).
@chalin chalin requested review from sfshaza2 and removed request for kwalrath January 25, 2019 00:00
sfshaza2
sfshaza2 approved these changes Jan 25, 2019
View reviewed changes
Copy link
Contributor
@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chalin, I really appreciate all you've done to update and improve this tutorial!

LGTM

@chalin
Copy link
Contributor Author
chalin commented Jan 25, 2019

I really appreciate all you've done to update and improve this tutorial!

😃I'm glad that you like it!

@chalin chalin merged commit 954b78c into master Jan 25, 2019
@chalin chalin deleted the chalin-interactive-0124 branch January 25, 2019 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfshaza2 sfshaza2 sfshaza2 approved these changes

Assignees
No one assigned
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chalin @sfshaza2 @googlebot