[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for osx aarch_64 #2

Merged
merged 1 commit into from
Mar 16, 2022
Merged

feat: add support for osx aarch_64 #2

merged 1 commit into from
Mar 16, 2022

Conversation

nitinshrm
Copy link
Contributor
  • Add logic to deduce aarch_64
  • Add print statement to inform user about supported versions
  • Add $osname-$osarch in print statement before download

@lucasls
Copy link
Contributor
lucasls commented Mar 16, 2022

Cool! ✅

@lucasls
Copy link
Contributor
lucasls commented Mar 16, 2022

@nitinshrm do Linux ARM64 binaries run os OS X?

@nitinshrm
Copy link
Contributor Author

@nitinshrm do Linux ARM64 binaries run os OS X?

@lucasls I just checked locally and it seems to fail.

@nitinshrm nitinshrm merged commit 52132ca into master Mar 16, 2022
@lucasls
Copy link
Contributor
lucasls commented Mar 17, 2022

@nitinshrm And what about downloading AMD64 if the OS is Mac OS? Afaik it would then run in x64 emulation mode

@nitinshrm
Copy link
Contributor Author

@nitinshrm And what about downloading AMD64 if the OS is Mac OS? Afaik it would then run in x64 emulation mode

Hi @lucasls sorry for a late response. I haven't tried it yet. Could you point me where I can find the AMD64 binaries?

@lucasls lucasls deleted the feature-add-support-for-aarch branch November 15, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timbuethe timbuethe timbuethe approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nitinshrm @lucasls @timbuethe