[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update strum #2724

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Update strum #2724

merged 2 commits into from
Feb 12, 2024

Conversation

richardpringle
Copy link
Contributor

Motivation

Simply (and hopefully) fixing the failures from the @dependabot PR -> #2718

Solution

Use the new name

PR Checklist

It's unfortunate that this is a breaking change, but I guess any dependency update is a breaking change...

  • Added Tests
  • Added Documentation
  • Breaking changes

Copy link
Collaborator
@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It's not a breaking change, just a deprecation of the old name. The test failures were unrelated.

@DaniPopes DaniPopes merged commit 2c10774 into gakonst:master Feb 12, 2024
16 of 18 checks passed
@richardpringle
Copy link
Contributor Author

Thanks! It's not a breaking change, just a deprecation of the old name. The test failures were unrelated.

Isn't updating strum always a breaking change? In any case, thanks for accepting the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants