[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21.09] fix JobWrapper: use correct fail method #14235

Draft
wants to merge 9 commits into
base: release_21.09
Choose a base branch
from
Draft

[21.09] fix JobWrapper: use correct fail method #14235

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
37b3225
add a test tool deleting output
bernt-matthias Jun 30, 2022
23b8cc2
JobWrapper: use correct fail method
bernt-matthias Jun 28, 2022
55e333d
remove output from test expected to fail
bernt-matthias Jul 5, 2022
45bd7ad
more precise error message
bernt-matthias Jul 5, 2022
4378b77
Update test/functional/tools/tool_deleting_output.xml
bernt-matthias Jul 6, 2022
1936272
Update test/functional/tools/tool_deleting_output.xml
bernt-matthias Jul 6, 2022
131576f
always check output file existence
bernt-matthias Aug 4, 2022
9e46bd3
reformulations in test tool help and comment
bernt-matthias Aug 4, 2022
d420389
only enumerate non-purged
bernt-matthias Aug 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
reformulations in test tool help and comment
  • Loading branch information
@bernt-matthias
bernt-matthias committed Aug 4, 2022
commit 9e46bd310bb1576591732dfc033fb6c4b48671df
6 changes: 3 additions & 3 deletions test/functional/tools/tool_deleting_output.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<tool id="tool_deleting_output" name="tool_deleting_output" version="0.1.0" license="AFL-3.0" profile="21.09">
<command><![CDATA[
rm '$out_file1' || true && ## alle sure that this does not fail.
rm '$out_file1' || true && ## ensure that this does not fail.
exit $exit_code
]]></command>
<inputs>
Expand All @@ -18,8 +18,8 @@ exit $exit_code
</test>
</tests>
<help><![CDATA[
This tool tests what happens if the underlying program removes the output data set,
it should fail independent of the exit code and the exit code should be correctly checked.
This tool tests what happens if the underlying program removes the output data set:
the job should fail independent of the exit code and the exit code should be correctly checked.

With outputs_to_working_directory this provoked https://github.com/galaxyproject/galaxy/issues/14206
]]></help>
Expand Down