[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Viz Plugins API #15574

Draft
wants to merge 11 commits into
base: dev
Choose a base branch
from
Draft

Migrate Viz Plugins API #15574

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
400add3
Initial cutover to fastapi for plugins
dannon Jan 21, 2023
e10dfc5
Fix return type, drop response_models
dannon Feb 13, 2023
3c99793
Drop old plugins API mapping causing app to fail loading
dannon Feb 13, 2023
5ef8333
Drop sample responses, fix up a few types
dannon Feb 13, 2023
deb5bc0
Four visualizations actually don't have a description set -- we shoul…
dannon Feb 13, 2023
d85f36f
Fix dataset_id and embeddable arguments, convert to formal from kwargs
dannon Feb 13, 2023
055faee
Drop double decoding -- handled as type
dannon Feb 13, 2023
bf01626
Use app-tethered url_for?
dannon Feb 14, 2023
03077cb
Use ProvidesHistoryContext -- we actually do need the current history…
dannon Feb 14, 2023
87b8690
Rename 'id' path param to 'plugin_id' for clarity.
dannon Feb 14, 2023
a47d2f4
REBASE/TEST -- use other url-builder?
dannon Mar 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Drop old plugins API mapping causing app to fail loading
  • Loading branch information
@dannon
dannon committed Nov 19, 2023
commit 3c99793b31dbd68d41b393c3c806e106f0e00cf8
1 change: 0 additions & 1 deletion lib/galaxy/webapps/galaxy/buildapp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,6 @@ def populate_api_routes(webapp, app):
)

webapp.mapper.resource("visualization", "visualizations", path_prefix="/api")
webapp.mapper.resource("plugins", "plugins", path_prefix="/api")
webapp.mapper.connect("/api/workflows/build_module", action="build_module", controller="workflows")
webapp.mapper.connect(
"/api/workflows/menu", action="set_workflow_menu", controller="workflows", conditions=dict(method=["PUT"])
Expand Down