[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[23.0] Fix extended metadata file size handling #16109

Merged
merged 2 commits into from
May 19, 2023
Merged

[23.0] Fix extended metadata file size handling #16109

merged 2 commits into from
May 19, 2023

Conversation

mvdbeek
Copy link
Member
@mvdbeek mvdbeek commented May 18, 2023

With test case from #14055

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek mvdbeek requested a review from jmchilton May 18, 2023 13:15
@github-actions github-actions bot added area/database Galaxy's database or data access layer area/testing area/testing/integration labels May 18, 2023
@github-actions github-actions bot added this to the 23.0 milestone May 18, 2023
jmchilton
jmchilton approved these changes May 18, 2023
View reviewed changes
Copy link
Member
@jmchilton jmchilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept meaning to return to this - I shouldn't have let it sit so long. Thanks for the fix. The linting problems seem legit.

@mvdbeek mvdbeek force-pushed the fix_extended_metdadata_file_size_handling branch from 3deb22f to d8ff7a5 Compare May 18, 2023 14:01
@mvdbeek mvdbeek merged commit 1f969c8 into galaxyproject:release_23.0 May 19, 2023
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmchilton jmchilton jmchilton approved these changes

Assignees
No one assigned
Labels
area/database Galaxy's database or data access layer area/testing/integration area/testing kind/bug
Projects
None yet
Milestone
23.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mvdbeek @jmchilton