[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.1] Backport pod5 datatype #18507

Merged
merged 4 commits into from
Jul 7, 2024
Merged

[24.1] Backport pod5 datatype #18507

merged 4 commits into from
Jul 7, 2024

Conversation

TomHarrop
Copy link
Contributor

These commits are already in dev, I'm attempting to backport the pod5 datatype as suggested. Hope I did it correctly!

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

TomHarrop and others added 4 commits July 7, 2024 20:03
@TomHarrop
add pod5
a8246ca 
(cherry picked from commit aa2b381)
@TomHarrop
reviews
47fea6e 
(cherry picked from commit 385e7ab)
@TomHarrop
tidy linting
8b93094 
(cherry picked from commit 46aeb76)
@TomHarrop
remove try except block
011a591 
(cherry picked from commit 5279f44)
@TomHarrop TomHarrop mentioned this pull request Jul 7, 2024
Merged
4 tasks
@nsoranzo nsoranzo changed the title Backport pod5 datatype [24.1] Backport pod5 datatype Jul 7, 2024
@nsoranzo nsoranzo added the merge label Jul 7, 2024
@martenson martenson merged commit 0d0e2a1 into galaxyproject:release_24.1 Jul 7, 2024
49 of 51 checks passed
@martenson
Copy link
Member
martenson commented Jul 7, 2024 •
edited
Loading

Thanks @TomHarrop !

I wonder if we should bring both direction converters to dev. ping @nsoranzo @bgruening ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgruening bgruening bgruening approved these changes

Assignees
No one assigned
Labels
area/datatypes area/UI-UX merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TomHarrop @martenson @bgruening @nsoranzo