[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug in the spike recording system #502

Merged
merged 3 commits into from
Feb 24, 2022
Merged

Conversation

tnowotny
Copy link
Member

… where for particular kernel…size and neuron population size combinations too many words were written into the spike recording buffer causing a memory error (but only discovered by compute-sanitize).

… size and neuron population size combinations

too many words were written into the spike recording buffer causing a memory error (but only discovered by compute-sanitize)
@codecov
Copy link
codecov bot commented Feb 18, 2022

Codecov Report

Merging #502 (9d43eee) into master (c86cefe) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #502   +/-   ##
=======================================
  Coverage   87.03%   87.03%           
=======================================
  Files          84       84           
  Lines       18103    18104    +1     
=======================================
+ Hits        15756    15757    +1     
  Misses       2347     2347           
Impacted Files Coverage Δ
src/genn/genn/code_generator/backendSIMT.cc 96.05% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c86cefe...9d43eee. Read the comment docs.

Copy link
Contributor
@neworderofjamie neworderofjamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - I had to push some tab->space changes though so could you check your text editor config?

@neworderofjamie neworderofjamie merged commit a84bfa9 into master Feb 24, 2022
@neworderofjamie neworderofjamie deleted the fix_spike_rec branch February 24, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants