[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamoDB: query() should use all range keys when sorting #7795

Merged

Conversation

bblommers
Copy link
Collaborator

Fixes #7788

@bblommers bblommers added this to the 5.0.10 milestone Jun 27, 2024
Copy link
codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.34%. Comparing base (4c99cbb) to head (5b2965c).

Files Patch % Lines
moto/dynamodb/models/table.py 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7795      +/-   ##
==========================================
- Coverage   94.34%   94.34%   -0.01%     
==========================================
  Files        1107     1107              
  Lines       93973    93972       -1     
==========================================
- Hits        88659    88658       -1     
  Misses       5314     5314              
Flag Coverage Δ
servertests 29.32% <0.00%> (+<0.01%) ⬆️
unittests 94.31% <94.11%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bblommers bblommers merged commit bd71c9c into getmoto:master Jun 28, 2024
42 checks passed
@bblommers bblommers deleted the dynamodb/query-gsi-without-range2 branch June 28, 2024 17:01
Copy link
Contributor

This is now part of moto >= 5.0.10.dev35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DynamoDB pagination not returning correct results for GSI when table has no range key
1 participant