[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): update dependencies #2827

Merged
merged 1 commit into from
Aug 19, 2021
Merged

chore(ci): update dependencies #2827

merged 1 commit into from
Aug 19, 2021

Conversation

mmorel-35
Copy link
Contributor
@mmorel-35 mmorel-35 commented Aug 16, 2021 •
edited
Loading
  • updates current dependencies
  • setup golangci-lint job
  • activate caches in workflow
  • configure dependabot

mmorel-35
mmorel-35 commented Aug 16, 2021
View reviewed changes
.github/workflows/gin.yml Outdated Show resolved Hide resolved
appleboy
appleboy requested changes Aug 17, 2021
View reviewed changes
.github/workflows/gin.yml Outdated Show resolved Hide resolved
@appleboy appleboy added this to the v1.8 milestone Aug 17, 2021
@codecov
Copy link
codecov bot commented Aug 17, 2021 •
edited
Loading

Codecov Report

Merging #2827 (6b55694) into master (b463b1c) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 6b55694 differs from pull request most recent head a14629f. Consider uploading reports for the commit a14629f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2827      +/-   ##
==========================================
+ Coverage   98.71%   98.75%   +0.04%     
==========================================
  Files          41       41              
  Lines        2100     3063     +963     
==========================================
+ Hits         2073     3025     +952     
- Misses         15       26      +11     
  Partials       12       12
Flag Coverage Δ
go-1.13 98.75% <100.00%> (?)
go-1.14 98.59% <100.00%> (?)
go-1.15 98.59% <100.00%> (?)
go-1.16 98.59% <100.00%> (?)
macos-latest 98.75% <100.00%> (?)
nomsgpack 98.74% <100.00%> (?)
ubuntu-latest 98.75% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
binding/protobuf.go 100.00% <ø> (ø)
mode.go 100.00% <ø> (ø)
render/protobuf.go 100.00% <ø> (ø)
binding/form_mapping.go 100.00% <100.00%> (ø)
binding/uri.go 100.00% <100.00%> (ø)
render/json.go 84.04% <100.00%> (-1.26%) ⬇️
gin.go 99.09% <0.00%> (-0.09%) ⬇️
utils.go 96.80% <0.00%> (-0.02%) ⬇️
fs.go 100.00% <0.00%> (ø)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b463b1c...a14629f. Read the comment docs.

appleboy
appleboy previously approved these changes Aug 17, 2021
View reviewed changes
@appleboy
Copy link
Member

@mmorel-35 why build fail?

@mmorel-35
Copy link
Contributor Author

It seems like a connection reset was received from codecov.io. Can you try to re-execute the workflow?

@appleboy
Copy link
Member

@mmorel-35 I found error from golangci-lint https://github.com/gin-gonic/gin/pull/2827/checks?check_run_id=3347171013

@mmorel-35
Copy link
Contributor Author

I know, but it's not the problem, I used continue-on-error to make it not a blocking error, take a look here https://github.com/gin-gonic/gin/pull/2827/checks?check_run_id=3347171427

@appleboy
Copy link
Member

We need to enable golangci-lint checker, not skip the error.

@mmorel-35 mmorel-35 marked this pull request as draft August 18, 2021 05:02
@mmorel-35
Copy link
Contributor Author
mmorel-35 commented Aug 18, 2021 •
edited
Loading

You mean that you want to activate the linter and fix the identified problems in the same PR ? Here are all the available errors and warnings :

  Error: var-naming: method BindUri should be BindURI (revive)
  Error: var-naming: func mapUri should be mapURI (revive)
  Error: exported: type name will be used as binding.BindingBody by other packages, and that stutters; consider calling this Body (revive)
  Error: exported: type name will be used as binding.BindingUri by other packages, and that stutters; consider calling this Uri (revive)
  Error: var-naming: var Uri should be URI (revive)
  Error: `data` is unused (structcheck)
  Error: `static` is unused (deadcode)
  Warning: var-naming: type AsciiJSON should be ASCIIJSON (revive)
  Warning: var-naming: method SecureJsonPrefix should be SecureJSONPrefix (revive)
  Warning: var-naming: func EnableJsonDecoderUseNumber should be EnableJSONDecoderUseNumber (revive)
  Warning: var-naming: func EnableJsonDecoderDisallowUnknownFields should be EnableJSONDecoderDisallowUnknownFields (revive)
  Warning: var-naming: method BindUri should be BindURI (revive)
  Warning: var-naming: method ShouldBindUri should be ShouldBindURI (revive)
  Warning: var-naming: method AsciiJSON should be ASCIIJSON (revive)
  Warning: context-keys-type: should not use basic type string as key in context.WithValue (revive)
  Error: SA1019: http.CloseNotifier has been deprecated since Go 1.11 and an alternative has been available since Go 1.7: the CloseNotifier interface predates Go's context package. New code should use Request.Context instead.  (staticcheck)
  Error: SA1019: http.CloseNotifier has been deprecated since Go 1.11 and an alternative has been available since Go 1.7: the CloseNotifier interface predates Go's context package. New code should use Request.Context instead.  (staticcheck)
  Error: SA1019: http.CloseNotifier has been deprecated since Go 1.11 and an alternative has been available since Go 1.7: the CloseNotifier interface predates Go's context package. New code should use Request.Context instead.  (staticcheck)

appleboy
appleboy reviewed Aug 18, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
@mmorel-35 mmorel-35 marked this pull request as ready for review August 18, 2021 09:23
appleboy
appleboy reviewed Aug 19, 2021
View reviewed changes
.github/workflows/gin.yml Outdated Show resolved Hide resolved
appleboy
appleboy requested changes Aug 19, 2021
View reviewed changes
.github/workflows/gin.yml Show resolved Hide resolved
appleboy
appleboy previously approved these changes Aug 19, 2021
View reviewed changes
@appleboy
Copy link
Member
appleboy commented Aug 19, 2021 •
edited
Loading

waiting for @thinkerou approval

@mmorel-35 @dependabot
chore(ci): update dependencies
a14629f 
- updates current dependencies
- setup golangci-lint job
- activate caches in workflow
- configure dependabot
- fix golangci-lint errors

Co-Authored-By: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-Authored-By: Matthieu MOREL <mmorel-35@users.noreply.github.com>
@mmorel-35
Copy link
Contributor Author

Alright, I squashed all the commits by the way

thinkerou
thinkerou approved these changes Aug 19, 2021
View reviewed changes
Copy link
Member
@thinkerou thinkerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,thanks👍

@appleboy appleboy merged commit 435a76b into gin-gonic:master Aug 19, 2021
@thinkerou thinkerou mentioned this pull request Aug 22, 2021
Closed
@thinkerou thinkerou mentioned this pull request Nov 25, 2021
Closed
daheige pushed a commit to daheige/gin that referenced this pull request Apr 18, 2022
@mmorel-35 @dependabot @daheige
chore(ci): update dependencies (gin-gonic#2827)
9624093 
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Matthieu MOREL <mmorel-35@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkerou thinkerou thinkerou approved these changes

@appleboy appleboy appleboy left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
3 participants
@mmorel-35 @appleboy @thinkerou