[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure a Python 2 pip is installed #316

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Conversation

The-Compiler
Copy link
Contributor

In the README of this repo, it's suggested to use the ubuntu-latest environment.
That environment will soon be upgraded to Ubuntu 20.04: actions/runner-images#1816

As pointed out in that issue, the updated image comes without a Python 2 pip preinstalled:

Setup Python dependencies
/home/runner/work/_actions/github/codeql-action/v1/python-setup/install_tools.sh
[...]
  + python2 -m pip install --user --upgrade pip setuptools wheel
  /usr/bin/python2: No module named pip
Warning: Unable to download and extract the tools needed for installing the python dependecies. You can call this action with 'setup-python-dependencies: false' to disable this process.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

In the README of this repo, it's suggested to use the `ubuntu-latest` environment.
That environment will soon be upgraded to Ubuntu 20.04: actions/runner-images#1816

As pointed out in that issue, the updated image comes without a Python 2 pip preinstalled:

    Setup Python dependencies
    /home/runner/work/_actions/github/codeql-action/v1/python-setup/install_tools.sh
    [...]
      + python2 -m pip install --user --upgrade pip setuptools wheel
      /usr/bin/python2: No module named pip
    Warning: Unable to download and extract the tools needed for installing the python dependecies. You can call this action with 'setup-python-dependencies: false' to disable this process.
The-Compiler added a commit to qutebrowser/qutebrowser that referenced this pull request Nov 20, 2020
It emits a setup warning because of a missing Python 2 pip otherwise:
github/codeql-action#316
Copy link
Contributor
@Daverlo Daverlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this ❤️

It will prevent us from failing when ubuntu-latest its updated.

@Daverlo Daverlo merged commit b15854c into github:main Nov 20, 2020
@The-Compiler The-Compiler deleted the patch-1 branch November 20, 2020 17:04
@The-Compiler
Copy link
Contributor Author

That was quick, thank you! Out of curiosity, when will I see this via github/codeql-action/init@v1 in my GitHub Actions workflow? (Just asking so I don't forget to revert my commit pinning Ubuntu 18.04 there)

@github-actions github-actions bot mentioned this pull request Nov 23, 2020
@Daverlo
Copy link
Contributor
Daverlo commented Nov 23, 2020

It got there today! We create the merge PR every Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants