[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: generate quota APIs by go-swagger #14300

Merged
merged 1 commit into from
Feb 26, 2021
Merged

Conversation

heww
Copy link
Contributor
@heww heww commented Feb 24, 2021

Signed-off-by: He Weiwei hweiwei@vmware.com

@codecov
Copy link
codecov bot commented Feb 24, 2021

Codecov Report

Merging #14300 (4b033c2) into master (a4a9953) will increase coverage by 0.29%.
The diff coverage is 77.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14300      +/-   ##
==========================================
+ Coverage   62.69%   62.99%   +0.29%     
==========================================
  Files         913      914       +1     
  Lines       61065    61552     +487     
  Branches     2024     2020       -4     
==========================================
+ Hits        38285    38774     +489     
- Misses      18847    18848       +1     
+ Partials     3933     3930       -3     
Flag Coverage Δ
unittests 62.99% <77.61%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/models/project.go 36.92% <ø> (ø)
src/server/v2.0/handler/handler.go 0.00% <0.00%> (ø)
src/server/v2.0/handler/project.go 0.00% <0.00%> (ø)
src/server/v2.0/handler/model/quota.go 50.00% <50.00%> (ø)
src/server/v2.0/handler/quota.go 95.34% <95.34%> (ø)
src/pkg/quota/types/resources.go 84.44% <100.00%> (+0.35%) ⬆️
src/controller/quota/options.go 71.42% <0.00%> (-28.58%) ⬇️
src/lib/cache/util.go 73.68% <0.00%> (-15.79%) ⬇️
src/controller/quota/controller.go 43.53% <0.00%> (-14.29%) ⬇️
src/common/api/base.go 54.76% <0.00%> (-9.53%) ⬇️
... and 12 more

Copy link
Contributor
@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: He Weiwei <hweiwei@vmware.com>
@ywk253100 ywk253100 merged commit fba6dd7 into goharbor:master Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants