[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ldap API to new program model #14351

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Move ldap API to new program model #14351

merged 1 commit into from
Mar 10, 2021

Conversation

stonezdj
Copy link
Contributor
@stonezdj stonezdj commented Mar 3, 2021

Fix some issue with the LDAP connection test

Signed-off-by: stonezdj stonezdj@gmail.com

@stonezdj stonezdj requested review from ywk253100 and heww March 3, 2021 14:43
@codecov
Copy link
codecov bot commented Mar 3, 2021 •
edited
Loading

Codecov Report

Merging #14351 (5a35b7a) into master (b181d4d) will increase coverage by 0.31%.
The diff coverage is 49.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14351      +/-   ##
==========================================
+ Coverage   64.23%   64.54%   +0.31%     
==========================================
  Files         916      918       +2     
  Lines       64235    64859     +624     
  Branches     2034     2034              
==========================================
+ Hits        41260    41862     +602     
- Misses      19024    19034      +10     
- Partials     3951     3963      +12
Flag Coverage Δ
unittests 64.54% <49.42%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/api/usergroup.go 46.66% <ø> (ø)
src/server/v2.0/handler/handler.go 0.00% <0.00%> (ø)
src/server/v2.0/handler/ldap.go 0.00% <0.00%> (ø)
src/controller/ldap/controller.go 45.45% <45.45%> (ø)
src/core/auth/ldap/ldap.go 46.85% <50.00%> (-0.67%) ⬇️
src/pkg/ldap/manager.go 53.62% <53.62%> (ø)
src/pkg/ldap/ldap.go 75.96% <70.37%> (ø)
src/core/config/config.go 78.23% <100.00%> (ø)
src/pkg/ldap/filter.go 100.00% <100.00%> (ø)
src/common/config/metadata/value.go 46.87% <0.00%> (-6.25%) ⬇️
... and 10 more

@stonezdj stonezdj force-pushed the 21feb26_ldap_refact branch 4 times, most recently from 18381e8 to 4e3d8d9 Compare March 5, 2021 02:07
@stonezdj stonezdj requested a review from wy65701436 March 5, 2021 02:34
wy65701436
wy65701436 approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor
@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj
Move ldap API to new program model
5a35b7a 
Fix some issue with the LDAP connection test

Signed-off-by: stonezdj <stonezdj@gmail.com>
@stonezdj stonezdj merged commit 035caad into goharbor:master Mar 10, 2021
@stonezdj stonezdj mentioned this pull request Mar 12, 2021
Closed
This was referenced Mar 12, 2021
Closed
Closed
@httaotao httaotao mentioned this pull request Apr 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heww heww heww approved these changes

@wy65701436 wy65701436 wy65701436 approved these changes

@ywk253100 ywk253100 Awaiting requested review from ywk253100

Assignees

@wy65701436 wy65701436

@heww heww

@ywk253100 ywk253100

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stonezdj @wy65701436 @heww @ywk253100