[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: generate search API by go-swagger #14422

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

heww
Copy link
Contributor
@heww heww commented Mar 11, 2021

Signed-off-by: He Weiwei hweiwei@vmware.com

@codecov
Copy link
codecov bot commented Mar 12, 2021

Codecov Report

Merging #14422 (ebf0306) into master (0d4992a) will decrease coverage by 5.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14422      +/-   ##
==========================================
- Coverage   69.73%   64.67%   -5.07%     
==========================================
  Files         682      920     +238     
  Lines       53734    65511   +11777     
  Branches        0     2034    +2034     
==========================================
+ Hits        37470    42366    +4896     
- Misses      13013    19195    +6182     
- Partials     3251     3950     +699     
Flag Coverage Δ
unittests 64.67% <0.00%> (-5.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/dao/repository.go 62.50% <0.00%> (-13.62%) ⬇️
src/server/v2.0/handler/handler.go 0.00% <0.00%> (ø)
src/server/v2.0/handler/search.go 0.00% <0.00%> (ø)
src/common/models/project.go 29.23% <0.00%> (-7.70%) ⬇️
src/controller/project/controller.go 36.48% <0.00%> (-1.36%) ⬇️
src/server/v2.0/restapi/configure_harbor.go 9.11% <0.00%> (-0.08%) ⬇️
src/server/v2.0/restapi/embedded_spec.go 100.00% <0.00%> (ø)
...s/label/label-signpost/label-signpost.component.ts 33.33% <0.00%> (ø)
...app/account/sign-in/top-repo/top-repo.component.ts 66.66% <0.00%> (ø)
... and 239 more

Signed-off-by: He Weiwei <hweiwei@vmware.com>
Copy link
Contributor
@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@heww heww merged commit a2b0844 into goharbor:master Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants