[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in NOTARYURL variable name #14681

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

bitsf
Copy link
Contributor
@bitsf bitsf commented Apr 17, 2021

Fixed typo in NOTARYURL variable name.

Signed-off-by: Ziming Zhang <zziming@vmware.com>
@bitsf bitsf mentioned this pull request Apr 17, 2021
@codecov
Copy link
codecov bot commented Apr 17, 2021

Codecov Report

Merging #14681 (39f7028) into master (5f0e7cf) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14681      +/-   ##
==========================================
+ Coverage   66.21%   66.23%   +0.01%     
==========================================
  Files         940      940              
  Lines       74487    74487              
  Branches     2124     2124              
==========================================
+ Hits        49322    49335      +13     
+ Misses      21273    21258      -15     
- Partials     3892     3894       +2     
Flag Coverage Δ
unittests 66.23% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/vulnerability/vulnerability-config.component.ts 47.00% <0.00%> (-5.99%) ⬇️
src/portal/src/app/shared/units/shared.utils.ts 23.07% <0.00%> (-1.29%) ⬇️
...ion-dialog/global-confirmation-dialog.component.ts 41.46% <0.00%> (+2.43%) ⬆️
src/controller/event/topic.go 10.81% <0.00%> (+9.00%) ⬆️
src/common/rbac/system/namespace.go 44.44% <0.00%> (+11.11%) ⬆️
src/controller/event/handler/auditlog/auditlog.go 61.11% <0.00%> (+50.00%) ⬆️

Copy link
Contributor
@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member
@ninjadq ninjadq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@reasonerjt reasonerjt merged commit c701ce0 into goharbor:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants